Patchwork [26/27] BKL: Remove BKL from ubifs

login
register
mail settings
Submitter Jan Blunck
Date Nov. 2, 2009, 10:05 a.m.
Message ID <1257156307-24175-27-git-send-email-jblunck@suse.de>
Download mbox | patch
Permalink /patch/37404/
State New
Headers show

Comments

Jan Blunck - Nov. 2, 2009, 10:05 a.m.
BKL is only used in get_sb. It is safe to remove it.

Signed-off-by: Jan Blunck <jblunck@suse.de>
---
 fs/ubifs/super.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
Artem Bityutskiy - Nov. 3, 2009, 5:47 a.m.
On Mon, 2009-11-02 at 11:05 +0100, Jan Blunck wrote:
> BKL is only used in get_sb. It is safe to remove it.
> 
> Signed-off-by: Jan Blunck <jblunck@suse.de>
Acked-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Patch

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 04a0fc9..333e181 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -2029,8 +2029,6 @@  static int ubifs_get_sb(struct file_system_type *fs_type, int flags,
 	struct super_block *sb;
 	int err;
 
-	lock_kernel();
-
 	dbg_gen("name %s, flags %#x", name, flags);
 
 	/*
@@ -2042,7 +2040,6 @@  static int ubifs_get_sb(struct file_system_type *fs_type, int flags,
 	if (IS_ERR(ubi)) {
 		ubifs_err("cannot open \"%s\", error %d",
 			  name, (int)PTR_ERR(ubi));
-		unlock_kernel();
 		return PTR_ERR(ubi);
 	}
 	ubi_get_volume_info(ubi, &vi);
@@ -2080,14 +2077,12 @@  static int ubifs_get_sb(struct file_system_type *fs_type, int flags,
 	ubi_close_volume(ubi);
 
 	simple_set_mnt(mnt, sb);
-	unlock_kernel();
 	return 0;
 
 out_deact:
 	deactivate_locked_super(sb);
 out_close:
 	ubi_close_volume(ubi);
-	unlock_kernel();
 	return err;
 }