diff mbox

[PULL,for-2.1,1/2] fix full frame updates for VNC clients

Message ID 1406190486-16026-2-git-send-email-kraxel@redhat.com
State New
Headers show

Commit Message

Gerd Hoffmann July 24, 2014, 8:28 a.m. UTC 
From: Stephan Kulow <coolo@suse.de>

If the client asks for !incremental frame updates, it has lost its content
so dirty doesn't matter - it has to see the full frame, so setting force_update

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Peter Lieven <pl@kamp.de>
---
 ui/vnc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Andreas Färber July 24, 2014, 12:30 p.m. UTC | #1 
Stephan,

Am 24.07.2014 10:28, schrieb Gerd Hoffmann:
> From: Stephan Kulow <coolo@suse.de>
> 
> If the client asks for !incremental frame updates, it has lost its content
> so dirty doesn't matter - it has to see the full frame, so setting force_update
> 

Can you please sign off your (trivial) patch via reply?

> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Reviewed-by: Peter Lieven <pl@kamp.de>
> ---

Thanks,
Andreas
Stephan Kulow July 24, 2014, 1:45 p.m. UTC | #2 
On 24.07.2014 14:30, Andreas Färber wrote:
> Stephan,
> 
> Am 24.07.2014 10:28, schrieb Gerd Hoffmann:
>> From: Stephan Kulow <coolo@suse.de>
>>
>> If the client asks for !incremental frame updates, it has lost its content
>> so dirty doesn't matter - it has to see the full frame, so setting force_update
>>
> 
> Can you please sign off your (trivial) patch via reply?

You mean confirming it was my patch? Yes, it was.

Greetings, Stephan
Andreas Färber July 24, 2014, 1:57 p.m. UTC | #3 
Am 24.07.2014 15:45, schrieb Stephan Kulow:
> On 24.07.2014 14:30, Andreas Färber wrote:
>> Am 24.07.2014 10:28, schrieb Gerd Hoffmann:
>>> From: Stephan Kulow <coolo@suse.de>
>>>
>>> If the client asks for !incremental frame updates, it has lost its content
>>> so dirty doesn't matter - it has to see the full frame, so setting force_update
>>>
>>
>> Can you please sign off your (trivial) patch via reply?
> 
> You mean confirming it was my patch? Yes, it was.

Yes, in the sense of written-by-you - that's expected to be indicated
the kernel way through a "Signed-off-by: Your name <your@email>" line,
usually automated via git commit -s.

Cheers,
Andreas
diff mbox

Patch

diff --git a/ui/vnc.c b/ui/vnc.c
index 548588a..06d6ca0 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -1878,6 +1878,7 @@  static void framebuffer_update_request(VncState *vs, int incremental,
         return;
     }
 
+    vs->force_update = 1;
     vnc_set_area_dirty(vs->dirty, width, height, x, y, w, h);
 }