From patchwork Fri Oct 30 15:34:52 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 37310 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id CFC14B7C36 for ; Sat, 31 Oct 2009 02:35:17 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932455AbZJ3PfF (ORCPT ); Fri, 30 Oct 2009 11:35:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932429AbZJ3PfF (ORCPT ); Fri, 30 Oct 2009 11:35:05 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:53037 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932394AbZJ3PfE (ORCPT ); Fri, 30 Oct 2009 11:35:04 -0400 Received: from nehalam (pool-71-117-243-237.ptldor.fios.verizon.net [71.117.243.237]) (authenticated bits=0) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id n9UFYwCk027267 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 30 Oct 2009 08:35:01 -0700 Date: Fri, 30 Oct 2009 08:34:52 -0700 From: Stephen Hemminger To: David Miller Cc: bphilips@suse.de, netdev@vger.kernel.org Subject: Re: [PATCH] sky2: set carrier off in probe Message-ID: <20091030083452.68ca227e@nehalam> In-Reply-To: <20091029.213816.35637194.davem@davemloft.net> References: <20091030035128.GA3380@jenkins.home.ifup.org> <20091029.211219.182331672.davem@davemloft.net> <20091030043050.GB3380@jenkins.home.ifup.org> <20091029.213816.35637194.davem@davemloft.net> Organization: Linux Foundation X-Mailer: Claws Mail 3.6.1 (GTK+ 2.16.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Spam-Status: No, hits=-5.775 required=5 tests=AWL, BAYES_00, FH_HOST_EQ_VERIZON_P, OSDL_HEADER_SUBJECT_BRACKETED, PATCH_SUBJECT_OSDL, RDNS_DYNAMIC X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Why not fix the problem in a generic way? --- Subject: ethtool: link is only up if device is running Signed-off-by: Stephen Hemminger -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/net/core/ethtool.c 2009-10-30 08:32:52.584728610 -0700 +++ b/net/core/ethtool.c 2009-10-30 08:33:31.806667877 -0700 @@ -27,7 +27,7 @@ u32 ethtool_op_get_link(struct net_device *dev) { - return netif_carrier_ok(dev) ? 1 : 0; + return netif_running(dev) && netif_carrier_ok(dev); } u32 ethtool_op_get_rx_csum(struct net_device *dev)