Message ID | 1406166546-21738-1-git-send-email-roy.qing.li@gmail.com |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show |
On Thu, Jul 24, 2014 at 09:49:06AM +0800, roy.qing.li@gmail.com wrote: > From: Li RongQing <roy.qing.li@gmail.com> > > This reverts commit a9232076374334ca2bc2a448dfde96d38a54349a. Any reason you didn't cc: the people on that patch, nor the people that get_maintainer.pl says to? Odds are Felipe will miss this one... greg k-h -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 24, 2014 at 10:06 AM, Greg KH <greg@kroah.com> wrote: >> This reverts commit a9232076374334ca2bc2a448dfde96d38a54349a. > > Any reason you didn't cc: the people on that patch, nor the people that > get_maintainer.pl says to? > > Odds are Felipe will miss this one... jeff.westfahl@ni.com has been Cced, I think Felipe Balbi is maintainer of usb, and I send it to linux-usb@vger.kernel.org, Felipe Balbi can see it. Ok, next time, I will use get_maintainer.pl -Roy crash as eth_start_xmit tries to use resources that gether_disconnect is freeing. Use netif_tx_lock/unlock around netif_stop_queue to ensure no threads are executing during the remainder of gether_disconnect. Signed-off-by: Jeff Westfahl <jeff.westfahl@ni.com> Tested-by: Jaeden Amero <jaeden.amero@ni.com> Signed-off-by: Felipe Balbi <balbi@ti.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/gadget/u_ether.c b/drivers/usb/gadget/u_ether.c index 97b0277..3d78a88 100644 --- a/drivers/usb/gadget/u_ether.c +++ b/drivers/usb/gadget/u_ether.c @@ -1120,10 +1120,7 @@ void gether_disconnect(struct gether *link) DBG(dev, "%s\n", __func__); - netif_tx_lock(dev->net); netif_stop_queue(dev->net); - netif_tx_unlock(dev->net); - netif_carrier_off(dev->net); /* disable endpoints, forcing (synchronous) completion