Patchwork Fix some packaging mistakes detected by lintian.

login
register
mail settings
Submitter Max
Date July 22, 2014, 3:07 p.m.
Message ID <1406041637-14296-1-git-send-email-max.suraev@fairwaves.co>
Download mbox | patch
Permalink /patch/372505/
State New
Headers show

Comments

Max - July 22, 2014, 3:07 p.m.
Signed-off-by: Max Suraev <max.suraev@fairwaves.co>
---
 debian/changelog | 2 +-
 debian/control   | 9 ++++++++-
 debian/copyright | 5 +----
 3 files changed, 10 insertions(+), 6 deletions(-)
Max - July 22, 2014, 3:13 p.m.
Since the latest discussion about uploading .deb packages into official Debian repo
I've decided to help a bit by fixing various errors and warnings. All the errors are
fixed except for those related to start/stop scripts because I think the right course
would be to drop them entirely and use systemd's .service files instead. The
remaining warnings are either about lack of manpage or some debian-specific changelog
version magic which I've failed to understand from reading its description - someone
with better English skills should volunteer to fix both :)
Holger Freyther - July 30, 2014, 6:46 a.m.
On Tue, Jul 22, 2014 at 05:07:17PM +0200, Max Suraev wrote:

> -Standards-Version: 3.8.4
> +Standards-Version: 3.9.5

So on which distributions can we build packages then. Using the
latest version is all nice but if I can't build for Debian 6.0
then you didn't do me a favor. :)

holger
Max - Aug. 6, 2014, 11:04 a.m.
My bad - I'm using too much of a bleeding edge :)
Put whatever works for your main build machine.

30.07.2014 08:46, Holger Hans Peter Freyther пишет:
> On Tue, Jul 22, 2014 at 05:07:17PM +0200, Max Suraev wrote:
> 
>> -Standards-Version: 3.8.4
>> +Standards-Version: 3.9.5
> 
> So on which distributions can we build packages then. Using the
> latest version is all nice but if I can't build for Debian 6.0
> then you didn't do me a favor. :)
> 
> holger
>

Patch

diff --git a/debian/changelog b/debian/changelog
index 815d30b..bd2c2b6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -62,6 +62,6 @@  openbsc (0.9.13.115.eb113-1) natty; urgency=low
 
 openbsc (0.9.4-1) unstable; urgency=low
 
-  * Initial release (Closes: #nnnn)  <nnnn is the bug number of your ITP>
+  * Initial release
 
  -- Harald Welte <laforge@gnumonks.org>  Tue, 24 Aug 2010 13:34:24 +0200
diff --git a/debian/control b/debian/control
index 7576455..fc7c8ba 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@  Section: net
 Priority: optional
 Maintainer: Harald Welte <laforge@gnumonks.org>
 Build-Depends: debhelper (>= 7.0.0~), autotools-dev, pkg-config, libgtp-dev, libosmocore-dev, libosmo-sccp-dev, libdbi0-dev, dh-autoreconf, libosmo-abis-dev, libdbd-sqlite3
-Standards-Version: 3.8.4
+Standards-Version: 3.9.5
 Homepage: http://openbsc.osmocom.org/
 Vcs-Git: git://bs11-abis.gnumonks.org/openbsc.git
 Vcs-Browser: http://openbsc.osmocom.org/trac/browser
@@ -12,36 +12,43 @@  Package: osmocom-bsc
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, libosmocore, libosmo-sccp
 Description: GSM Base Station Controller; BSC-only version of OpenBSC.  Needs a real MSC!
+ Classical BSC which requires MSC to operate.
 
 Package: osmocom-nitb
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, libosmocore, libdbd-sqlite3, libdbi1
 Description: GSM Network-in-a-Box, implements BSC, MSC, SMSC, HLR, VLR
+ All the GSM network components bundled together.
 
 Package: osmocom-ipaccess-utils
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, libosmocore
 Description: Command line utilities for ip.access nanoBTS
+ Utilities specific for ip.access unit.
 
 Package: osmocom-bs11-utils
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, libosmocore
 Description: Command line utilities for Siemens BS-11 BTS
+ Utilities specific for BS-11 unit.
 
 Package: osmocom-sgsn
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, libosmocore, libgtp
 Description: Osmocom Serving GPRS Support Node
+ SGSN implementation.
 
 Package: osmocom-gbproxy
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, libosmocore
 Description: Osmocom GPRS Gb Interface Proxy
+ Proxy for Gb interface.
 
 Package: osmocom-bsc-nat
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, libosmocore
 Description: Osmocom Base Station Controller Network Address Translation
+ Network address translation for BSC.
 
 Package: osmocom-bsc-dbg
 Architecture: any
diff --git a/debian/copyright b/debian/copyright
index 09693c9..fbac90c 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -6,7 +6,7 @@  It was downloaded from:
 
     git://bs11-abis.gnumonks.org/openbsc.git
 
-Upstream Author(s):
+Upstream Authors:
 
     Harald Welte <laforge@gnumonks.org>
     Dieter Spaar <spaar@mirider.augusta.de>
@@ -45,6 +45,3 @@  The Debian packaging is:
 
 and is licensed under the GPL version 3,
 see "/usr/share/common-licenses/GPL-3".
-
-# Please also look if there are files or directories which have a
-# different copyright/license attached and list them here.