Patchwork [AArch64,tests] Skip graphite tests that don't fit -mcmodel=tiny

login
register
mail settings
Submitter Kyrylo Tkachov
Date July 22, 2014, 11:01 a.m.
Message ID <53CE448E.4060109@arm.com>
Download mbox | patch
Permalink /patch/372440/
State New
Headers show

Comments

Kyrylo Tkachov - July 22, 2014, 11:01 a.m.
Hi all,

These tests use very large arrays as part of their loop interchange 
testing so they don't fit into the 1MiB binary size limit imposed by 
-mcmodel=tiny. This causes errors at link-time.

Skip them when that is the case.

Ok to commit?

Thanks,
Kyrill

2014-07-22  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     * gcc.dg/graphite/interchange-0.c: Skip on aarch64 tiny memory model.
     * gcc.dg/graphite/interchange-1.c: Likewise.
     * gcc.dg/graphite/interchange-2.c: Likewise.
     * gcc.dg/graphite/interchange-3.c: Likewise.
     * gcc.dg/graphite/interchange-4.c: Likewise.
     * gcc.dg/graphite/interchange-10.c: Likewise.
     * gcc.dg/graphite/interchange-11.c: Likewise.
     * gcc.dg/graphite/interchange-15.c: Likewise.
     * gcc.dg/graphite/interchange-mvt.c: Likewise.
     * gcc.dg/graphite/pr46185.c: Likewise.
Sebastian Pop - July 22, 2014, 3:01 p.m.
On Tue, Jul 22, 2014 at 6:01 AM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
> Hi all,
>
> These tests use very large arrays as part of their loop interchange testing
> so they don't fit into the 1MiB binary size limit imposed by -mcmodel=tiny.
> This causes errors at link-time.
>
> Skip them when that is the case.
>
> Ok to commit?

Looks good to me.
Please wait for the review of a maintainer of the testsuite before committing.

Thanks,
Sebastian

>
> Thanks,
> Kyrill
>
> 2014-07-22  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>     * gcc.dg/graphite/interchange-0.c: Skip on aarch64 tiny memory model.
>     * gcc.dg/graphite/interchange-1.c: Likewise.
>     * gcc.dg/graphite/interchange-2.c: Likewise.
>     * gcc.dg/graphite/interchange-3.c: Likewise.
>     * gcc.dg/graphite/interchange-4.c: Likewise.
>     * gcc.dg/graphite/interchange-10.c: Likewise.
>     * gcc.dg/graphite/interchange-11.c: Likewise.
>     * gcc.dg/graphite/interchange-15.c: Likewise.
>     * gcc.dg/graphite/interchange-mvt.c: Likewise.
>     * gcc.dg/graphite/pr46185.c: Likewise.
Kyrylo Tkachov - July 22, 2014, 3:04 p.m.
On 22/07/14 16:01, Sebastian Pop wrote:
> On Tue, Jul 22, 2014 at 6:01 AM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
>> Hi all,
>>
>> These tests use very large arrays as part of their loop interchange testing
>> so they don't fit into the 1MiB binary size limit imposed by -mcmodel=tiny.
>> This causes errors at link-time.
>>
>> Skip them when that is the case.
>>
>> Ok to commit?
> Looks good to me.
> Please wait for the review of a maintainer of the testsuite before committing.

Thanks for having a look.
CC'ing Mike as testsuite maintainer then...

Kyrill

> Thanks,
> Sebastian
>
>> Thanks,
>> Kyrill
>>
>> 2014-07-22  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>>
>>      * gcc.dg/graphite/interchange-0.c: Skip on aarch64 tiny memory model.
>>      * gcc.dg/graphite/interchange-1.c: Likewise.
>>      * gcc.dg/graphite/interchange-2.c: Likewise.
>>      * gcc.dg/graphite/interchange-3.c: Likewise.
>>      * gcc.dg/graphite/interchange-4.c: Likewise.
>>      * gcc.dg/graphite/interchange-10.c: Likewise.
>>      * gcc.dg/graphite/interchange-11.c: Likewise.
>>      * gcc.dg/graphite/interchange-15.c: Likewise.
>>      * gcc.dg/graphite/interchange-mvt.c: Likewise.
>>      * gcc.dg/graphite/pr46185.c: Likewise.

Patch

commit 1c4e93c3cd0904fc2860fc7c4f9f1e0bffc72d2c
Author: Kyrylo Tkachov <kyrylo.tkachov@arm.com>
Date:   Wed Jul 16 16:29:58 2014 +0100

    [AArch64] Skip some graphite tests for -mcmodel=tiny

diff --git a/gcc/testsuite/gcc.dg/graphite/interchange-0.c b/gcc/testsuite/gcc.dg/graphite/interchange-0.c
index 8bc6e13..58e24b6 100644
--- a/gcc/testsuite/gcc.dg/graphite/interchange-0.c
+++ b/gcc/testsuite/gcc.dg/graphite/interchange-0.c
@@ -1,4 +1,5 @@ 
 /* { dg-require-effective-target size32plus } */
+/* { dg-skip-if "AArch64 tiny code model does not support programs larger than 1MiB" {aarch64_tiny} {"*"} {""} } */
 
 #define DEBUG 0
 
diff --git a/gcc/testsuite/gcc.dg/graphite/interchange-1.c b/gcc/testsuite/gcc.dg/graphite/interchange-1.c
index b4559d1..bf725d7 100644
--- a/gcc/testsuite/gcc.dg/graphite/interchange-1.c
+++ b/gcc/testsuite/gcc.dg/graphite/interchange-1.c
@@ -1,4 +1,5 @@ 
 /* { dg-require-effective-target size32plus } */
+/* { dg-skip-if "AArch64 tiny code model does not support programs larger than 1MiB" {aarch64_tiny} {"*"} {""} } */
 
 /* Formerly known as ltrans-1.c */
 
diff --git a/gcc/testsuite/gcc.dg/graphite/interchange-10.c b/gcc/testsuite/gcc.dg/graphite/interchange-10.c
index 51a46d6..4a38d2c 100644
--- a/gcc/testsuite/gcc.dg/graphite/interchange-10.c
+++ b/gcc/testsuite/gcc.dg/graphite/interchange-10.c
@@ -1,4 +1,5 @@ 
 /* { dg-require-effective-target size32plus } */
+/* { dg-skip-if "AArch64 tiny code model does not support programs larger than 1MiB" {aarch64_tiny} {"*"} {""} } */
 
 #define DEBUG 0
 #if DEBUG
diff --git a/gcc/testsuite/gcc.dg/graphite/interchange-11.c b/gcc/testsuite/gcc.dg/graphite/interchange-11.c
index 491fda1..214e8f1 100644
--- a/gcc/testsuite/gcc.dg/graphite/interchange-11.c
+++ b/gcc/testsuite/gcc.dg/graphite/interchange-11.c
@@ -1,4 +1,5 @@ 
 /* { dg-require-effective-target size32plus } */
+/* { dg-skip-if "AArch64 tiny code model does not support programs larger than 1MiB" {aarch64_tiny} {"*"} {""} } */
 
 #define DEBUG 0
 #if DEBUG
diff --git a/gcc/testsuite/gcc.dg/graphite/interchange-15.c b/gcc/testsuite/gcc.dg/graphite/interchange-15.c
index d154b74..e5d52aa 100644
--- a/gcc/testsuite/gcc.dg/graphite/interchange-15.c
+++ b/gcc/testsuite/gcc.dg/graphite/interchange-15.c
@@ -1,4 +1,5 @@ 
 /* { dg-require-effective-target size32plus } */
+/* { dg-skip-if "AArch64 tiny code model does not support programs larger than 1MiB" {aarch64_tiny} {"*"} {""} } */
 
 #define DEBUG 0
 #if DEBUG
diff --git a/gcc/testsuite/gcc.dg/graphite/interchange-2.c b/gcc/testsuite/gcc.dg/graphite/interchange-2.c
index 2609a10..a199be5 100644
--- a/gcc/testsuite/gcc.dg/graphite/interchange-2.c
+++ b/gcc/testsuite/gcc.dg/graphite/interchange-2.c
@@ -1,4 +1,5 @@ 
 /* { dg-require-effective-target size32plus } */
+/* { dg-skip-if "AArch64 tiny code model does not support programs larger than 1MiB" {aarch64_tiny} {"*"} {""} } */
 
 /* Formerly known as ltrans-2.c */
 
diff --git a/gcc/testsuite/gcc.dg/graphite/interchange-3.c b/gcc/testsuite/gcc.dg/graphite/interchange-3.c
index 1419749..7d4d1e2 100644
--- a/gcc/testsuite/gcc.dg/graphite/interchange-3.c
+++ b/gcc/testsuite/gcc.dg/graphite/interchange-3.c
@@ -1,4 +1,5 @@ 
 /* { dg-require-effective-target size32plus } */
+/* { dg-skip-if "AArch64 tiny code model does not support programs larger than 1MiB" {aarch64_tiny} {"*"} {""} } */
 
 /* Formerly known as ltrans-3.c */
 
diff --git a/gcc/testsuite/gcc.dg/graphite/interchange-4.c b/gcc/testsuite/gcc.dg/graphite/interchange-4.c
index f86391c..806a57f 100644
--- a/gcc/testsuite/gcc.dg/graphite/interchange-4.c
+++ b/gcc/testsuite/gcc.dg/graphite/interchange-4.c
@@ -1,4 +1,5 @@ 
 /* { dg-require-effective-target size32plus } */
+/* { dg-skip-if "AArch64 tiny code model does not support programs larger than 1MiB" {aarch64_tiny} {"*"} {""} } */
 
 /* Formerly known as ltrans-4.c */
 
diff --git a/gcc/testsuite/gcc.dg/graphite/interchange-mvt.c b/gcc/testsuite/gcc.dg/graphite/interchange-mvt.c
index f446dbe..f10efa5 100644
--- a/gcc/testsuite/gcc.dg/graphite/interchange-mvt.c
+++ b/gcc/testsuite/gcc.dg/graphite/interchange-mvt.c
@@ -1,4 +1,5 @@ 
 /* { dg-require-effective-target size32plus } */
+/* { dg-skip-if "AArch64 tiny code model does not support programs larger than 1MiB" {aarch64_tiny} {"*"} {""} } */
 
 #define DEBUG 0
 #if DEBUG
diff --git a/gcc/testsuite/gcc.dg/graphite/pr46185.c b/gcc/testsuite/gcc.dg/graphite/pr46185.c
index 36d46a4..646a733 100644
--- a/gcc/testsuite/gcc.dg/graphite/pr46185.c
+++ b/gcc/testsuite/gcc.dg/graphite/pr46185.c
@@ -1,4 +1,5 @@ 
 /* { dg-do run } */
+/* { dg-skip-if "AArch64 tiny code model does not support programs larger than 1MiB" {aarch64_tiny} {"*"} {""} } */
 /* { dg-options "-O2 -floop-interchange -ffast-math -fno-ipa-cp" } */
 
 #define DEBUG 0