| Message ID | 53CDF537.1040104@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c index b5b593c..c7f1af6 100644 --- a/fs/ubifs/file.c +++ b/fs/ubifs/file.c @@ -1540,11 +1540,9 @@ static const struct vm_operations_struct ubifs_file_vm_ops = { static int ubifs_file_mmap(struct file *file, struct vm_area_struct *vma) { - int err; + struct address_space *mapping = file->f_mapping; - err = generic_file_mmap(file, vma); - if (err) - return err; + file_accessed(file); vma->vm_ops = &ubifs_file_vm_ops; return 0; }
generic_file_mmap() set vma->vm_ops = &generic_file_vm_ops, then ubifs_file_mmap set vma->vm_ops = &ubifs_file_vm_ops. So it is redundant. And there is no kind of file does not supply page reading function in ubifs. The readpage() check up for mmap file in generic_file_mmap() is not needed. So remove the call of generic_file_mmap(). Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com> --- fs/ubifs/file.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)