Message ID | 1405994779-19207-1-git-send-email-computersforpeace@gmail.com |
---|---|
State | Accepted |
Commit | 36c6a7ac74044b8025488c018279115bb3c32eb0 |
Headers | show |
On Mon, Jul 21, 2014 at 07:06:19PM -0700, Brian Norris wrote: > The variable 'retries' is never modified, so if the reset operation > never is going to complete, we'll get stuck in an infinite loop. > > It looks like the intention was to decrement 'retries' on every loop. > Untested. > > Caught by Coverity. > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> Pushed this and my other Coverity-inspired patches to l2-mtd.git/next. Brian
diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index 5a4bfe33112a..6da141af9cba 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -2029,6 +2029,8 @@ static int cfi_amdstd_panic_wait(struct map_info *map, struct flchip *chip, udelay(1); } + + retries--; } /* the chip never became ready */
The variable 'retries' is never modified, so if the reset operation never is going to complete, we'll get stuck in an infinite loop. It looks like the intention was to decrement 'retries' on every loop. Untested. Caught by Coverity. Signed-off-by: Brian Norris <computersforpeace@gmail.com> --- Untested drivers/mtd/chips/cfi_cmdset_0002.c | 2 ++ 1 file changed, 2 insertions(+)