| Message ID | 1405960243-589-1-git-send-email-ttynkkynen@nvidia.com |
|---|---|
| State | Not Applicable |
| Headers | show |
On Mon, Jul 21, 2014 at 07:30:43PM +0300, Tuomas Tynkkynen wrote: I guess it's same issue and fix as: http://patchwork.ozlabs.org/patch/370629/ Thanks, Gavin >Forward declaring struct pci_dev in aer.h avoids this warning: > >In file included from include/ras/ras_event.h:11:0, > from drivers/ras/ras.c:13: >include/linux/aer.h:38:44: warning: 'struct pci_dev’ declared inside parameter list [enabled by default] >include/linux/aer.h:38:44: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] > >Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com> >--- > include/linux/aer.h | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/include/linux/aer.h b/include/linux/aer.h >index 4dbaa70..d9ec8dd 100644 >--- a/include/linux/aer.h >+++ b/include/linux/aer.h >@@ -7,6 +7,8 @@ > #ifndef _AER_H_ > #define _AER_H_ > >+struct pci_dev; >+ > #define AER_NONFATAL 0 > #define AER_FATAL 1 > #define AER_CORRECTABLE 2 >-- >1.8.1.5 > >-- >To unsubscribe from this list: send the line "unsubscribe linux-pci" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/21/2014 04:27 PM, Gavin Shan wrote: > On Mon, Jul 21, 2014 at 07:30:43PM +0300, Tuomas Tynkkynen wrote: > > I guess it's same issue and fix as: > > http://patchwork.ozlabs.org/patch/370629/ Yes, and it still needs to be merged.... :( > Thanks, > Gavin > >> Forward declaring struct pci_dev in aer.h avoids this warning: >> >> In file included from include/ras/ras_event.h:11:0, >> from drivers/ras/ras.c:13: >> include/linux/aer.h:38:44: warning: 'struct pci_dev’ declared inside parameter list [enabled by default] >> include/linux/aer.h:38:44: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] >> >> Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com> >> --- >> include/linux/aer.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/linux/aer.h b/include/linux/aer.h >> index 4dbaa70..d9ec8dd 100644 >> --- a/include/linux/aer.h >> +++ b/include/linux/aer.h >> @@ -7,6 +7,8 @@ >> #ifndef _AER_H_ >> #define _AER_H_ >> >> +struct pci_dev; >> + >> #define AER_NONFATAL 0 >> #define AER_FATAL 1 >> #define AER_CORRECTABLE 2 >> --
diff --git a/include/linux/aer.h b/include/linux/aer.h index 4dbaa70..d9ec8dd 100644 --- a/include/linux/aer.h +++ b/include/linux/aer.h @@ -7,6 +7,8 @@ #ifndef _AER_H_ #define _AER_H_ +struct pci_dev; + #define AER_NONFATAL 0 #define AER_FATAL 1 #define AER_CORRECTABLE 2
Forward declaring struct pci_dev in aer.h avoids this warning: In file included from include/ras/ras_event.h:11:0, from drivers/ras/ras.c:13: include/linux/aer.h:38:44: warning: 'struct pci_dev’ declared inside parameter list [enabled by default] include/linux/aer.h:38:44: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com> --- include/linux/aer.h | 2 ++ 1 file changed, 2 insertions(+)