Patchwork [i386,PR61827] Fix fuse-caller-save-xmm.c test-case

login
register
mail settings
Submitter Tom de Vries
Date July 21, 2014, 11:33 a.m.
Message ID <53CCFAA2.2010709@mentor.com>
Download mbox | patch
Permalink /patch/372039/
State New
Headers show

Comments

Tom de Vries - July 21, 2014, 11:33 a.m.
On 21-07-14 12:40, Uros Bizjak wrote:
> On Mon, Jul 21, 2014 at 12:34 PM, Tom de Vries <Tom_deVries@mentor.com> wrote:
>
>> Dominique noticed that the .LC0 check failed on darwin, since the label LC0
>> is used. This follow-up patch fixes that (and I see now you already Ok-ed
>> this change).
>>
>> Furthermore, I've realized from the comments in the PR that for
>> solaris/sun-as and darwin no cfi directives are generated. There are two
>> other i386 fuse-caller-save tests which test cfi directives. The reason
>> these tests aren't failing for solaris/sun-as and darwin like the
>> fuse-caller-save-xmm test did, is because they test for the absence of
>> specific cfi directives, which will always pass if no cfi directives are
>> generated. So I've removed the cfi directive checks (and removed superfluous
>> mains) and added tests on instructions.
>>
>>
>> Tested with -m32 and -m64.
>>
>> OK for trunk?
>
> This is OK.
>

Dominique noticed a symbol matching problem on darwin for fuse-caller-save-rec.c.

I've committed this followup patch that fixes that problem.

Thanks,
- Tom

Patch

2014-07-21  Tom de Vries  <tom@codesourcery.com>

	PR target/61827
	* gcc.target/i386/fuse-caller-save-rec.c: Allow underscore prefix to bar
	symbol in scan-assembler-times call check.

diff --git a/gcc/testsuite/gcc.target/i386/fuse-caller-save-rec.c b/gcc/testsuite/gcc.target/i386/fuse-caller-save-rec.c
index d1441bc..a0fcf9c 100644
--- a/gcc/testsuite/gcc.target/i386/fuse-caller-save-rec.c
+++ b/gcc/testsuite/gcc.target/i386/fuse-caller-save-rec.c
@@ -26,5 +26,4 @@  foo (int y)
 /* { dg-final { scan-assembler-times "addl\t%\[re\]?dx, %\[re\]?ax" 1 } } */
 
 /* Verify that bar is self-recursive.  */
-/* { dg-final { scan-assembler-times "call\tbar" 2 } } */
-
+/* { dg-final { scan-assembler-times "call\t_?bar" 2 } } */