From patchwork Thu Oct 29 15:01:18 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: qemu-kvm-0.11 regression, crashes on older guests with virtio network Date: Thu, 29 Oct 2009 05:01:18 -0000 From: Dustin Kirkland X-Patchwork-Id: 37199 Message-Id: <1256828478.25064.126.camel@x200> To: Mark McLoughlin Cc: Rusty Russell , Scott Tsai , qemu-devel , kvm On Thu, 2009-10-29 at 14:48 +0000, Mark McLoughlin wrote: > Ah, it all makes sense now. > > I was getting confused between HOST_* and GUEST_* > > this should have been: > > features |= (1 << VIRTIO_NET_F_MAC); > features |= (1 << VIRTIO_NET_F_HOST_CSUM); > features |= (1 << VIRTIO_NET_F_HOST_TSO4); > features |= (1 << VIRTIO_NET_F_HOST_TSO6); > features |= (1 << VIRTIO_NET_F_HOST_ECN); > > Could you try that Dustin? Hmm, not sure I'm doing this correctly... I tried changing the following, but looks like I might also have to define these as well, since: /tmp/qemu-kvm/qemu-kvm/hw/virtio-net.c:167: error: ‘VIRTIO_NET_F_HOST_CSUM’ undeclared (first use in this function) Signed-off-by: Mark McLoughlin Acked-by: Mark McLoughlin diff --git a/hw/virtio-net.c b/hw/virtio-net.c index ce8e6cb..6582e69 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -164,10 +164,10 @@ static uint32_t virtio_net_bad_features(VirtIODevice *vdev) /* Linux kernel 2.6.25. It understood MAC (as everyone must), * but also these: */ features |= (1 << VIRTIO_NET_F_MAC); - features |= (1 << VIRTIO_NET_F_GUEST_CSUM); - features |= (1 << VIRTIO_NET_F_GUEST_TSO4); - features |= (1 << VIRTIO_NET_F_GUEST_TSO6); - features |= (1 << VIRTIO_NET_F_GUEST_ECN); + features |= (1 << VIRTIO_NET_F_HOST_CSUM); + features |= (1 << VIRTIO_NET_F_HOST_TSO4); + features |= (1 << VIRTIO_NET_F_HOST_TSO6); + features |= (1 << VIRTIO_NET_F_HOST_ECN); return features & virtio_net_get_features(vdev); }