Patchwork Hide the caret for -Wstack-usage

login
register
mail settings
Submitter Eric Botcazou
Date July 19, 2014, 7:28 p.m.
Message ID <1881183.IYVnV5uid3@polaris>
Download mbox | patch
Permalink /patch/371857/
State New
Headers show

Comments

Eric Botcazou - July 19, 2014, 7:28 p.m.
> I personally don't like much this pattern of saving a variable, doing
> something and then restoring it.

Right, it's kludgy, so I have only changed the location in the end.

Tested on x86_64-suse-linux, applied on all active branches as obvious.


2014-07-19  Eric Botcazou  <ebotcazou@adacore.com>

        * toplev.c (output_stack_usage): Adjust the location of the warning.


2014-07-19  Eric Botcazou  <ebotcazou@adacore.com>

        * gcc.dg/stack-usage-2.c: Adjust.

Patch

Index: toplev.c
===================================================================
--- toplev.c	(revision 212833)
+++ toplev.c	(working copy)
@@ -1052,16 +1052,19 @@  output_stack_usage (void)
 
   if (warn_stack_usage >= 0)
     {
+      const location_t loc = DECL_SOURCE_LOCATION (current_function_decl);
+
       if (stack_usage_kind == DYNAMIC)
-	warning (OPT_Wstack_usage_, "stack usage might be unbounded");
+	warning_at (loc, OPT_Wstack_usage_, "stack usage might be unbounded");
       else if (stack_usage > warn_stack_usage)
 	{
 	  if (stack_usage_kind == DYNAMIC_BOUNDED)
-	    warning (OPT_Wstack_usage_, "stack usage might be %wd bytes",
-		     stack_usage);
+	    warning_at (loc,
+			OPT_Wstack_usage_, "stack usage might be %wd bytes",
+			stack_usage);
 	  else
-	    warning (OPT_Wstack_usage_, "stack usage is %wd bytes",
-		     stack_usage);
+	    warning_at (loc, OPT_Wstack_usage_, "stack usage is %wd bytes",
+			stack_usage);
 	}
     }
 }
Index: testsuite/gcc.dg/stack-usage-2.c
===================================================================
--- testsuite/gcc.dg/stack-usage-2.c	(revision 212833)
+++ testsuite/gcc.dg/stack-usage-2.c	(working copy)
@@ -1,33 +1,32 @@ 
 /* { dg-do compile } */
 /* { dg-options "-Wstack-usage=512" } */
 
-int foo1 (void)
+int foo1 (void)  /* { dg-bogus "stack usage" } */
 {
   char arr[16];
   arr[0] = 1;
   return 0;
-} /* { dg-bogus "stack usage" } */
+}
 
-int foo2 (void)
+int foo2 (void)  /* { dg-warning "stack usage is \[0-9\]* bytes" } */
 {
   char arr[1024];
   arr[0] = 1;
   return 0;
-} /* { dg-warning "stack usage is \[0-9\]* bytes" } */
+}
 
-int foo3 (void)
+int foo3 (void) /* { dg-warning "stack usage might be \[0-9\]* bytes" } */
 {
   char arr[1024] __attribute__((aligned (512)));
   arr[0] = 1;
   /* Force dynamic realignment of argument pointer.  */
   __builtin_apply ((void (*)()) foo2, 0, 0);
   return 0;
+}
 
-} /* { dg-warning "stack usage might be \[0-9\]* bytes" } */
-
-int foo4 (int n)
+int foo4 (int n) /* { dg-warning "stack usage might be unbounded" } */
 {
   char arr[n];
   arr[0] = 1;
   return 0;
-} /* { dg-warning "stack usage might be unbounded" } */
+}