Message ID | 1405697725-23866-1-git-send-email-andrey.krieger.utkin@gmail.com |
---|---|
State | Not Applicable |
Headers | show |
On Fri, 2014-07-18 at 18:35 +0300, Andrey Utkin wrote: > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80581 > Reported-by: David Binderman <dcb314@hotmail.com> > Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com> Hi, thanks, but I already have a patch which does the same in the linux-ubifs.git tree: commit b793a8c8885d87d9867fb2dbfdc1ef7b5877d71b Author: hujianyang <hujianyang@huawei.com> Date: Wed Jun 11 10:42:52 2014 +0800 UBIFS: remove useless statements This patch removes useless and duplicate statements. Signed-off-by: hujianyang <hujianyang@huawei.com> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
diff --git a/fs/ubifs/sb.c b/fs/ubifs/sb.c index 4c37607..c2c3d13 100644 --- a/fs/ubifs/sb.c +++ b/fs/ubifs/sb.c @@ -447,7 +447,7 @@ static int validate_sb(struct ubifs_info *c, struct ubifs_sb_node *sup) goto failed; } - if (c->default_compr < 0 || c->default_compr >= UBIFS_COMPR_TYPES_CNT) { + if (c->default_compr >= UBIFS_COMPR_TYPES_CNT) { err = 13; goto failed; } diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index e5bd068..9c59c10 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c @@ -75,7 +75,7 @@ static int validate_inode(struct ubifs_info *c, const struct inode *inode) return 1; } - if (ui->compr_type < 0 || ui->compr_type >= UBIFS_COMPR_TYPES_CNT) { + if (ui->compr_type >= UBIFS_COMPR_TYPES_CNT) { ubifs_err("unknown compression type %d", ui->compr_type); return 2; }
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80581 Reported-by: David Binderman <dcb314@hotmail.com> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com> --- fs/ubifs/sb.c | 2 +- fs/ubifs/super.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)