Message ID | 1405672963-16069-1-git-send-email-rick.taylor@cassidian.com |
---|---|
State | Changes Requested |
Headers | show |
Dear Rick Taylor, On Fri, 18 Jul 2014 09:42:41 +0100, Rick Taylor wrote: > Signed-off-by: Rick Taylor <rick.taylor@cassidian.com> > --- > package/pkg-autotools.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks. However, the commit log is not properly formatted. With git, the commit log should have one line of less than ~80 characters that summarizes the commit, then one empty new line, and then more details. Also, in Buildroot, we like when the commit title has a prefix that identifies the area of the change. I.e, in your case, something like: === pkg-autotools: add support for <pkg>_AUTORECONF_ENV This commit improves the autotools-package infrastructure to support a <pkg>_AUTORECONF_ENV variable, which allows to pass addition variables in the environment of the autoreconf execution. This is useful in the situation where blabla blibli ... Signed-off-by: ... === Could you update your commit log with this format? Thomas
diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk index 557413d..255c42d 100644 --- a/package/pkg-autotools.mk +++ b/package/pkg-autotools.mk @@ -228,7 +228,7 @@ endef # define AUTORECONF_HOOK @$$(call MESSAGE,"Autoreconfiguring") - $$(Q)cd $$($$(PKG)_SRCDIR) && $$(AUTORECONF) $$($$(PKG)_AUTORECONF_OPT) + $$(Q)cd $$($$(PKG)_SRCDIR) && $$($$(PKG)_AUTORECONF_ENV) $$(AUTORECONF) $$($$(PKG)_AUTORECONF_OPT) $$(Q)if test "$$($$(PKG)_LIBTOOL_PATCH)" = "YES"; then \ for i in `find $$($$(PKG)_SRCDIR) -name ltmain.sh`; do \ ltmain_version=`sed -n '/^[ ]*VERSION=/{s/^[ ]*VERSION=//;p;q;}' $$$$i | \
Signed-off-by: Rick Taylor <rick.taylor@cassidian.com> --- package/pkg-autotools.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)