Patchwork vmxnet3: remove duplicate #include

login
register
mail settings
Submitter Shreyas Bhatewara
Date Oct. 28, 2009, 4:30 p.m.
Message ID <alpine.LRH.2.00.0910280910250.24555@sbhatewara-dev1.eng.vmware.com>
Download mbox | patch
Permalink /patch/37120/
State Accepted
Delegated to: David Miller
Headers show

Comments

Shreyas Bhatewara - Oct. 28, 2009, 4:30 p.m.
Remove duplicate headerfile includes from vmxnet3_int.h

Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com>
Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: Bhavesh Davda <davda@vmware.com>

---

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bhavesh Davda - Oct. 28, 2009, 4:32 p.m.
Correction:

< Signed-off-by: Bhavesh Davda <davda@vmware.com>
> Signed-off-by: Bhavesh Davda <bhavesh@vmware.com>

Thanks

- Bhavesh
 
Bhavesh P. Davda

> -----Original Message-----
> From: pv-drivers-bounces@vmware.com [mailto:pv-drivers-
> bounces@vmware.com] On Behalf Of Shreyas Bhatewara
> Sent: Wednesday, October 28, 2009 9:31 AM
> To: netdev@vger.kernel.org
> Cc: pv-drivers@vmware.com; weiyi.huang@gmail.com
> Subject: [Pv-drivers] [PATCH] vmxnet3: remove duplicate #include
> 
> 
> Remove duplicate headerfile includes from vmxnet3_int.h
> 
> Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com>
> Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
> Signed-off-by: Bhavesh Davda <davda@vmware.com>
> 
> ---
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_int.h
> b/drivers/net/vmxnet3/vmxnet3_int.h
> index 3c0d70d..4450816 100644
> --- a/drivers/net/vmxnet3/vmxnet3_int.h
> +++ b/drivers/net/vmxnet3/vmxnet3_int.h
> @@ -27,16 +27,11 @@
>  #ifndef _VMXNET3_INT_H
>  #define _VMXNET3_INT_H
> 
> -#include <linux/types.h>
>  #include <linux/ethtool.h>
>  #include <linux/delay.h>
> -#include <linux/device.h>
>  #include <linux/netdevice.h>
>  #include <linux/pci.h>
> -#include <linux/ethtool.h>
>  #include <linux/compiler.h>
> -#include <linux/module.h>
> -#include <linux/moduleparam.h>
>  #include <linux/slab.h>
>  #include <linux/spinlock.h>
>  #include <linux/ioport.h>
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers@vmware.com
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 29, 2009, 5:29 a.m.
From: Shreyas Bhatewara <sbhatewara@vmware.com>
Date: Wed, 28 Oct 2009 09:30:40 -0700 (PDT)

> 
> Remove duplicate headerfile includes from vmxnet3_int.h
> 
> Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com>
> Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
> Signed-off-by: Bhavesh Davda <davda@vmware.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 29, 2009, 5:52 a.m.
From: David Miller <davem@davemloft.net>
Date: Wed, 28 Oct 2009 22:29:01 -0700 (PDT)

> From: Shreyas Bhatewara <sbhatewara@vmware.com>
> Date: Wed, 28 Oct 2009 09:30:40 -0700 (PDT)
> 
>> 
>> Remove duplicate headerfile includes from vmxnet3_int.h
>> 
>> Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com>
>> Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
>> Signed-off-by: Bhavesh Davda <davda@vmware.com>
> 
> Applied.

Guys, I'd like to remove the X86 Kconfig requirement for this
driver.  There really isn't any x86 specific code in the
driver, it uses only standard PCI and networking APIs to function.

I know the virtual hardware won't be seen on other platforms,
but allowing the driver to get build tested on non-x86 platforms
helps me a lot.  I do all of my build verifications on sparc64
for example.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bhavesh Davda - Oct. 29, 2009, 1:35 p.m.
> From: David Miller <davem@davemloft.net>
> Date: Wed, 28 Oct 2009 22:29:01 -0700 (PDT)
> 
> > From: Shreyas Bhatewara <sbhatewara@vmware.com>
> > Date: Wed, 28 Oct 2009 09:30:40 -0700 (PDT)
> >
> >>
> >> Remove duplicate headerfile includes from vmxnet3_int.h
> >>
> >> Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com>
> >> Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
> >> Signed-off-by: Bhavesh Davda <davda@vmware.com>
> >
> > Applied.
> 
> Guys, I'd like to remove the X86 Kconfig requirement for this
> driver.  There really isn't any x86 specific code in the
> driver, it uses only standard PCI and networking APIs to function.
> 
> I know the virtual hardware won't be seen on other platforms,
> but allowing the driver to get build tested on non-x86 platforms
> helps me a lot.  I do all of my build verifications on sparc64
> for example.

The driver shares in-memory data structures with the device emulation in the hypervisor, so in the VMware case since they are both on x86, we don't need any cpu_to_le32 or le32_to_cpu's when accessing them. But for correctness, if you were to compile the vmxnet3 driver for a big-endian architecture like sparc64, we will need to sprinkle those around all accesses to the shared data structures.

In other words, don't just trivially remove the X86 Kconfig requirement for this driver.

Thanks

- Bhavesh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 29, 2009, 1:50 p.m.
From: Bhavesh Davda <bhavesh@vmware.com>
Date: Thu, 29 Oct 2009 06:35:35 -0700

> In other words, don't just trivially remove the X86 Kconfig
> requirement for this driver.

Then I assume you're going to add the endianness handling
and send me a patch soon?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Shreyas Bhatewara - Oct. 29, 2009, 5:06 p.m.
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Thursday, October 29, 2009 6:50 AM
> To: Bhavesh Davda
> Cc: Shreyas Bhatewara; pv-drivers@vmware.com; netdev@vger.kernel.org;
> weiyi.huang@gmail.com
> Subject: Re: [Pv-drivers] [PATCH] vmxnet3: remove duplicate #include
> 
> From: Bhavesh Davda <bhavesh@vmware.com>
> Date: Thu, 29 Oct 2009 06:35:35 -0700
> 
> > In other words, don't just trivially remove the X86 Kconfig
> > requirement for this driver.
> 
> Then I assume you're going to add the endianness handling
> and send me a patch soon?

Yes, I will post a patch soon.

Thanks.
->Shreyas
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h
index 3c0d70d..4450816 100644
--- a/drivers/net/vmxnet3/vmxnet3_int.h
+++ b/drivers/net/vmxnet3/vmxnet3_int.h
@@ -27,16 +27,11 @@ 
 #ifndef _VMXNET3_INT_H
 #define _VMXNET3_INT_H
 
-#include <linux/types.h>
 #include <linux/ethtool.h>
 #include <linux/delay.h>
-#include <linux/device.h>
 #include <linux/netdevice.h>
 #include <linux/pci.h>
-#include <linux/ethtool.h>
 #include <linux/compiler.h>
-#include <linux/module.h>
-#include <linux/moduleparam.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
 #include <linux/ioport.h>