From patchwork Thu Jul 17 11:22:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marat Zakirov X-Patchwork-Id: 371071 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 0FF75140171 for ; Thu, 17 Jul 2014 21:22:55 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=J1HUotqgFE4vIgod1 Dk1K2rxzMFApe/D/2MowUf29iFMWg9MPb1FwEVevQ3pIg0BuXdQcZHfhfbnQ5aOq Vx6p+/WfqUaBBhgpDnVbQ8A6bAEV1r1kXPw/dWTE/4I0H77IpZj5SrH+jllcHuZR vJA5vsTQTcrpmWFfWHjJtkzSJc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=9Scu4oBlplWKuEiZx/a9sxl k6ZE=; b=IrszmNKAGN7qJwPULadwPFqsdhkSLoVWJFoeL0AZx0cxy0FJ1Is/O7a V8qqBfQgnhMtD/8wqPiUqxtxVNjE0AAG3D4e0e1/fB9Dvt/ZQccn+wWU6Vm8yABv OhwSu89tYrPPdbz59rHqQQ3A34pkHqQTTgJuxG9iMwYZ/hJvxsvU= Received: (qmail 18259 invoked by alias); 17 Jul 2014 11:22:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 18242 invoked by uid 89); 17 Jul 2014 11:22:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mailout2.w1.samsung.com Received: from mailout2.w1.samsung.com (HELO mailout2.w1.samsung.com) (210.118.77.12) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (DES-CBC3-SHA encrypted) ESMTPS; Thu, 17 Jul 2014 11:22:45 +0000 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N8U003T7SXCHA60@mailout2.w1.samsung.com> for gcc-patches@gcc.gnu.org; Thu, 17 Jul 2014 12:22:24 +0100 (BST) Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id CE.68.19257.102B7C35; Thu, 17 Jul 2014 12:22:41 +0100 (BST) Received: from [106.109.129.103] by eusync1.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0N8U002BGSXSJD50@eusync1.samsung.com>; Thu, 17 Jul 2014 12:22:41 +0100 (BST) Message-id: <53C7B202.3070401@samsung.com> Date: Thu, 17 Jul 2014 15:22:42 +0400 From: Marat Zakirov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-version: 1.0 To: Kyrill Tkachov , Christophe Lyon Cc: "gcc-patches@gcc.gnu.org" , Ramana Radhakrishnan , Richard Earnshaw , Slava Garbuzov , Yury Gribov Subject: Re: [PING][PATCH] Fix for PR 61561 References: <53BE8EA4.7080803@arm.com> <53BFA9A9.4090209@samsung.com> <53C64468.9000506@samsung.com> <53C646BB.6020905@arm.com> In-reply-to: <53C646BB.6020905@arm.com> Content-type: multipart/mixed; boundary=------------040105080609090809070300 On 07/16/2014 01:32 PM, Kyrill Tkachov wrote: > > On 16/07/14 10:22, Marat Zakirov wrote: >> Christophe, >> >> Please look at a new patch. Draft tests are OK. >> I'll ask your commit approval when full regression (ARM/thumb1/thumb2) >> tests are done. > Hi Marat, > > I was about to propose the thumb2.md hunk myself, but I'll defer to > the arm maintainers to comment on the other parts. > > Also, in the ChangeLog it is helpful to specify which patterns are > being affected, so in your case it would be something like: > > * config/arm/thumb1.md (*thumb1_movhi_insn): Handle stack pointer. > (*thumb1_movqi_insn): Likewise. > * config/arm/thumb2.md (*thumb2_movhi_insn): Ditto. > > > Kyrill > > Christophe, Kirill, finally I've finished regression testing. Please check if my patch is OK for trunk. The following configures were used: configure --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --target=arm-linux-gnueabi --with-interwork --enable-long-long --enable-languages=c,c++,fortran --enable-shared --with-gnu-as --with-gnu-ld --with-arch=$ARCH --with-mode=$MODE Thumb-1 $ARCH=armv4t $MODE=thumb Thumb-2 $ARCH=armv7 $MODE=thumb ARM $ARCH=armv7-a $MODE=arm No regressions detected, test pr61561.c passed in all cases. Thank you all. --Marat gcc/ChangeLog: 2014-07-16 Marat Zakirov * config/arm/thumb1.md (*thumb1_movhi_insn): Handle stack pointer. (*thumb1_movqi_insn): Likewise. * config/arm/thumb2.md (*thumb2_movhi_insn): Likewise. diff --git a/gcc/config/arm/thumb1.md b/gcc/config/arm/thumb1.md index c044fd5..47b5cbd 100644 --- a/gcc/config/arm/thumb1.md +++ b/gcc/config/arm/thumb1.md @@ -708,7 +708,7 @@ (define_insn "*thumb1_movhi_insn" [(set (match_operand:HI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l") - (match_operand:HI 1 "general_operand" "l,m,l,*h,*r,I"))] + (match_operand:HI 1 "general_operand" "lk,m,l,*h,*r,I"))] "TARGET_THUMB1 && ( register_operand (operands[0], HImode) || register_operand (operands[1], HImode))" @@ -762,7 +762,7 @@ (define_insn "*thumb1_movqi_insn" [(set (match_operand:QI 0 "nonimmediate_operand" "=l,l,m,*r,*h,l") - (match_operand:QI 1 "general_operand" "l, m,l,*h,*r,I"))] + (match_operand:QI 1 "general_operand" "lk, m,l,*h,*r,I"))] "TARGET_THUMB1 && ( register_operand (operands[0], QImode) || register_operand (operands[1], QImode))" diff --git a/gcc/config/arm/thumb2.md b/gcc/config/arm/thumb2.md index 6ea0810..7228069 100644 --- a/gcc/config/arm/thumb2.md +++ b/gcc/config/arm/thumb2.md @@ -318,7 +318,7 @@ ;; of the messiness associated with the ARM patterns. (define_insn "*thumb2_movhi_insn" [(set (match_operand:HI 0 "nonimmediate_operand" "=r,r,l,r,m,r") - (match_operand:HI 1 "general_operand" "r,I,Py,n,r,m"))] + (match_operand:HI 1 "general_operand" "rk,I,Py,n,r,m"))] "TARGET_THUMB2 && (register_operand (operands[0], HImode) || register_operand (operands[1], HImode))"