mbox

[GIT,net-next,v4] Open vSwitch

Message ID 1405556263-1653-1-git-send-email-pshelar@nicira.com
State Rejected, archived
Delegated to: David Miller
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/pshelar/openvswitch.git net_next_ovs

Message

Pravin B Shelar July 17, 2014, 12:17 a.m. UTC 
Following patches adds three features to OVS
1. Add fairness to upcall processing.
2. Recirculation and Hash action.
3. Enable Tunnel GSO features.
Rest of patches are bug fixes related to patches from same series.

v2 series changes first patch according to comment from Dave Miller.
v3 series changes first patch according to comment from Nikolay Aleksandrov.
v4 series changes recirc patch commit msg.
 
----------------------------------------------------------------
The following changes since commit 0854a7f13206d7523abe773235bbe4d13958fc4b:

  Merge branch 'amd811e-cleanups' (2014-07-14 19:14:44 -0700)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/pshelar/openvswitch.git net_next_ovs

for you to fetch changes up to 657ea8e11e187a80e8e070a4d5a0ca1d7a8533e3:

  openvswitch: Add skb_clone NULL check for the sampling action. (2014-07-16 16:58:25 -0700)

----------------------------------------------------------------
Alex Wang (1):
      openvswitch: Allow each vport to have an array of 'port_id's.

Andy Zhou (6):
      openvswitch: Add hash action
      openvswitch: Add recirc action
      openvswitch: Fix key size computation in key_attr_size()
      openvswitch: Avoid memory corruption in queue_userspace_packet()
      openvswitch: Add skb_clone NULL check in the recirc action.
      openvswitch: Add skb_clone NULL check for the sampling action.

Pravin B Shelar (2):
      openvswitch: Enable tunnel GSO for OVS bridge.
      net: Export xmit_recursion

Simon Horman (2):
      openvswitch: Free skb(s) on recirculation error
      openvswitch: Sample action without side effects

 include/linux/netdev_features.h      |   8 +++
 include/linux/netdevice.h            |   3 +
 include/uapi/linux/openvswitch.h     |  39 ++++++++++--
 net/core/dev.c                       |  10 +--
 net/openvswitch/actions.c            | 119 +++++++++++++++++++++++++++++++----
 net/openvswitch/datapath.c           |  79 ++++++++++++++++-------
 net/openvswitch/datapath.h           |   8 ++-
 net/openvswitch/flow.h               |   2 +
 net/openvswitch/flow_netlink.c       |  43 ++++++++++++-
 net/openvswitch/vport-internal_dev.c |   5 +-
 net/openvswitch/vport.c              |  99 ++++++++++++++++++++++++++++-
 net/openvswitch/vport.h              |  27 ++++++--
 12 files changed, 390 insertions(+), 52 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller July 17, 2014, 9:48 p.m. UTC | #1 
From: Pravin B Shelar <pshelar@nicira.com>
Date: Wed, 16 Jul 2014 17:17:43 -0700

> Following patches adds three features to OVS
> 1. Add fairness to upcall processing.
> 2. Recirculation and Hash action.
> 3. Enable Tunnel GSO features.
> Rest of patches are bug fixes related to patches from same series.
> 
> v2 series changes first patch according to comment from Dave Miller.
> v3 series changes first patch according to comment from Nikolay Aleksandrov.
> v4 series changes recirc patch commit msg.

Pulled, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller July 17, 2014, 9:57 p.m. UTC | #2 
From: David Miller <davem@davemloft.net>

Date: Thu, 17 Jul 2014 14:48:48 -0700 (PDT)

> From: Pravin B Shelar <pshelar@nicira.com>

> Date: Wed, 16 Jul 2014 17:17:43 -0700

> 

>> Following patches adds three features to OVS

>> 1. Add fairness to upcall processing.

>> 2. Recirculation and Hash action.

>> 3. Enable Tunnel GSO features.

>> Rest of patches are bug fixes related to patches from same series.

>> 

>> v2 series changes first patch according to comment from Dave Miller.

>> v3 series changes first patch according to comment from Nikolay Aleksandrov.

>> v4 series changes recirc patch commit msg.

> 

> Pulled, thanks.


Actually, reverted, this code doesn't even compile.

net/openvswitch/datapath.c: In function ‘ovs_dp_process_packet_with_key’:
net/openvswitch/datapath.c:271:43: error: ‘key’ undeclared (first use in this function)
net/openvswitch/datapath.c:271:43: note: each undeclared identifier is reported only once for each function it appears in

It would be a strong understatement to say that I'm disappointed at this.

Are you even build testing the tree you are asking me to pull from?  This
means you can't have possibly have functionally tested the code.
Pravin B Shelar July 17, 2014, 10:25 p.m. UTC | #3 
On Thu, Jul 17, 2014 at 2:57 PM, David Miller <davem@davemloft.net> wrote:
> From: David Miller <davem@davemloft.net>
> Date: Thu, 17 Jul 2014 14:48:48 -0700 (PDT)
>
>> From: Pravin B Shelar <pshelar@nicira.com>
>> Date: Wed, 16 Jul 2014 17:17:43 -0700
>>
>>> Following patches adds three features to OVS
>>> 1. Add fairness to upcall processing.
>>> 2. Recirculation and Hash action.
>>> 3. Enable Tunnel GSO features.
>>> Rest of patches are bug fixes related to patches from same series.
>>>
>>> v2 series changes first patch according to comment from Dave Miller.
>>> v3 series changes first patch according to comment from Nikolay Aleksandrov.
>>> v4 series changes recirc patch commit msg.
>>
>> Pulled, thanks.
>
> Actually, reverted, this code doesn't even compile.
>
> net/openvswitch/datapath.c: In function ‘ovs_dp_process_packet_with_key’:
> net/openvswitch/datapath.c:271:43: error: ‘key’ undeclared (first use in this function)
> net/openvswitch/datapath.c:271:43: note: each undeclared identifier is reported only once for each function it appears in
>
> It would be a strong understatement to say that I'm disappointed at this.
>
> Are you even build testing the tree you are asking me to pull from?  This
> means you can't have possibly have functionally tested the code.
>
Yesterday when I created my branch, net-next was not merged with net.
Now you have merged it. That resulted in conflict (due to commit
ad55200734c65a3ec5d0c39d6ea904008baea536) which was silently resolved
and as result you got error.

I did not refreshed my base net-next tree just before sending last
pull request Sorry about that.
I will update my branch to solve conflict send updated pull request.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html