Patchwork [net-next] atl1c: duplicate atl1c_get_tpd

login
register
mail settings
Submitter jie.yang@atheros.com
Date Oct. 28, 2009, 5:14 a.m.
Message ID <12567068551959-git-send-email-jie.yang@atheros.com>
Download mbox | patch
Permalink /patch/37052/
State Accepted
Delegated to: David Miller
Headers show

Comments

jie.yang@atheros.com - Oct. 28, 2009, 5:14 a.m.
From: Jie Yang <jie.yang@atheros.com>

remove duplicate atl1c_get_tpd, it may cause hardware to send wrong packets.

Signed-off-by: Jie Yang <jie.yang@atheros.com>

---

 drivers/net/atl1c/atl1c_main.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 28, 2009, 5:31 a.m.
From: <jie.yang@atheros.com>
Date: Wed, 28 Oct 2009 13:14:15 +0800

> From: Jie Yang <jie.yang@atheros.com>
> 
> remove duplicate atl1c_get_tpd, it may cause hardware to send wrong packets.
> 
> Signed-off-by: Jie Yang <jie.yang@atheros.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/atl1c/atl1c_main.c b/drivers/net/atl1c/atl1c_main.c
index 1372e9a..3b8801a 100644
--- a/drivers/net/atl1c/atl1c_main.c
+++ b/drivers/net/atl1c/atl1c_main.c
@@ -1981,8 +1981,6 @@  static void atl1c_tx_map(struct atl1c_adapter *adapter,
 		else {
 			use_tpd = atl1c_get_tpd(adapter, type);
 			memcpy(use_tpd, tpd, sizeof(struct atl1c_tpd_desc));
-			use_tpd = atl1c_get_tpd(adapter, type);
-			memcpy(use_tpd, tpd, sizeof(struct atl1c_tpd_desc));
 		}
 		buffer_info = atl1c_get_tx_buffer(adapter, use_tpd);
 		buffer_info->length = buf_len - mapped_len;