From patchwork Fri Oct 10 08:57:35 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarek Poplawski X-Patchwork-Id: 3699 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 9DC92DDFB2 for ; Fri, 10 Oct 2008 19:57:49 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbYJJI5p (ORCPT ); Fri, 10 Oct 2008 04:57:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752479AbYJJI5p (ORCPT ); Fri, 10 Oct 2008 04:57:45 -0400 Received: from ug-out-1314.google.com ([66.249.92.170]:56148 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751670AbYJJI5o (ORCPT ); Fri, 10 Oct 2008 04:57:44 -0400 Received: by ug-out-1314.google.com with SMTP id k3so1225766ugf.37 for ; Fri, 10 Oct 2008 01:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=c0yCIJaFUeUTbSfK3TWJzymlha5/AsjVPwnmtd9Q20A=; b=iEn4PMJEIFEZXi6JwebZAXefTN9f1rgqMgqkPDVAEq0BA3+msHgW4Bz376BvNunDZo brvrydBkui35Vfu1IrXJ5QWsis2xL0i5KCf8Ow7p0ORcYRxj1iF/hGwkMZ7hs8+dnlTH FaMF3cop21UD0MH/MB7Pv8jzaUCTCHG/1uFsk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=ANkIaoJUkOdezapnU6KSlRivOlCvQQ7fAWgst/sY3tpBoYj4PvOdED0qS7gCg0p7/Z RO1ryG2aF0y9U/ezQqqX0eZ+p2C/8do3y486dNp5r83FDadoh3sJngGqqPA0Vd+P3ycM YWvsyRYt2I2PYOYHOPbnbVQRAchZUT7lOp5YE= Received: by 10.67.92.17 with SMTP id u17mr411217ugl.75.1223629060424; Fri, 10 Oct 2008 01:57:40 -0700 (PDT) Received: from ff.dom.local (bv170.internetdsl.tpnet.pl [80.53.205.170]) by mx.google.com with ESMTPS id h6sm6488045nfh.21.2008.10.10.01.57.39 (version=SSLv3 cipher=RC4-MD5); Fri, 10 Oct 2008 01:57:39 -0700 (PDT) Date: Fri, 10 Oct 2008 08:57:35 +0000 From: Jarek Poplawski To: Patrick McHardy Cc: Simon Horman , netdev@vger.kernel.org, David Miller , Martin Devera Subject: Re: Possible regression in HTB Message-ID: <20081010085735.GA5946@ff.dom.local> References: <20081007220022.GA2664@ami.dom.local> <20081010065934.GA4762@ff.dom.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20081010065934.GA4762@ff.dom.local> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Oct 10, 2008 at 06:59:34AM +0000, Jarek Poplawski wrote: ... > But we could consider if, after removing requeuing which mattered > here, some change is needed in "proper" way of limiting such effects > of wrong parameters or hardware errors (like the size of mbuffer etc.)? Simon, If you could find "a minute", please try if this patch changes anything e.g. for n = 1000? Thanks, Jarek P. --- net/sched/sch_htb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c index d14f020..3fe0a98 100644 --- a/net/sched/sch_htb.c +++ b/net/sched/sch_htb.c @@ -1416,7 +1416,7 @@ static int htb_change_class(struct Qdisc *sch, u32 classid, /* set class to be in HTB_CAN_SEND state */ cl->tokens = hopt->buffer; cl->ctokens = hopt->cbuffer; - cl->mbuffer = 60 * PSCHED_TICKS_PER_SEC; /* 1min */ + cl->mbuffer = 10 * PSCHED_TICKS_PER_SEC; /* 10sec */ cl->t_c = psched_get_time(); cl->cmode = HTB_CAN_SEND;