Patchwork Possible regression in HTB

login
register
mail settings
Submitter Jarek Poplawski
Date Oct. 10, 2008, 8:57 a.m.
Message ID <20081010085735.GA5946@ff.dom.local>
Download mbox | patch
Permalink /patch/3699/
State RFC
Delegated to: David Miller
Headers show

Comments

Jarek Poplawski - Oct. 10, 2008, 8:57 a.m.
On Fri, Oct 10, 2008 at 06:59:34AM +0000, Jarek Poplawski wrote:
...
> But we could consider if, after removing requeuing which mattered
> here, some change is needed in "proper" way of limiting such effects
> of wrong parameters or hardware errors (like the size of mbuffer etc.)?

Simon,

If you could find "a minute", please try if this patch changes anything
e.g. for n = 1000?

Thanks,
Jarek P.

---

 net/sched/sch_htb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jarek Poplawski - Oct. 10, 2008, 12:12 p.m.
On Fri, Oct 10, 2008 at 08:57:35AM +0000, Jarek Poplawski wrote:
> On Fri, Oct 10, 2008 at 06:59:34AM +0000, Jarek Poplawski wrote:
> ...
> > But we could consider if, after removing requeuing which mattered
> > here, some change is needed in "proper" way of limiting such effects
> > of wrong parameters or hardware errors (like the size of mbuffer etc.)?
> 
> Simon,
> 
> If you could find "a minute", please try if this patch changes anything
> e.g. for n = 1000?

Hmm... this mbuffer change is not enough, let's forget it.

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
index d14f020..3fe0a98 100644
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c
@@ -1416,7 +1416,7 @@  static int htb_change_class(struct Qdisc *sch, u32 classid,
 		/* set class to be in HTB_CAN_SEND state */
 		cl->tokens = hopt->buffer;
 		cl->ctokens = hopt->cbuffer;
-		cl->mbuffer = 60 * PSCHED_TICKS_PER_SEC;	/* 1min */
+		cl->mbuffer = 10 * PSCHED_TICKS_PER_SEC;	/* 10sec */
 		cl->t_c = psched_get_time();
 		cl->cmode = HTB_CAN_SEND;