diff mbox

[resend] ip: add nlmon as a device type to help message

Message ID 1405414636-31362-1-git-send-email-yamato@redhat.com
State Not Applicable, archived
Delegated to: stephen hemminger
Headers show

Commit Message

Masatake YAMATO July 15, 2014, 8:57 a.m. UTC 
Though nlmon device can be added, it was not listed
in the output of "ip link help".

Acked-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
---
 ip/iplink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Borkmann July 15, 2014, 9:29 a.m. UTC | #1 
On 07/15/2014 10:57 AM, Masatake YAMATO wrote:
> Though nlmon device can be added, it was not listed
> in the output of "ip link help".
>
> Acked-by: Daniel Borkmann <dborkman@redhat.com>
> Signed-off-by: Masatake YAMATO <yamato@redhat.com>

No need to resend, your original patch is still queued
up here: http://patchwork.ozlabs.org/patch/358864/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Masatake YAMATO July 15, 2014, 9:55 a.m. UTC | #2 
> On 07/15/2014 10:57 AM, Masatake YAMATO wrote:
>> Though nlmon device can be added, it was not listed
>> in the output of "ip link help".
>>
>> Acked-by: Daniel Borkmann <dborkman@redhat.com>
>> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
> 
> No need to resend, your original patch is still queued
> up here: http://patchwork.ozlabs.org/patch/358864/

Oh, sorry. I don't know that. Thank you.

Masaake YAMATO
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stephen Hemminger July 15, 2014, 4:42 p.m. UTC | #3 
On Tue, 15 Jul 2014 17:57:16 +0900
Masatake YAMATO <yamato@redhat.com> wrote:

> Though nlmon device can be added, it was not listed
> in the output of "ip link help".
> 
> Acked-by: Daniel Borkmann <dborkman@redhat.com>
> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
> ---
>  ip/iplink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ip/iplink.c b/ip/iplink.c
> index de9ef5d..5e428da 100644
> --- a/ip/iplink.c
> +++ b/ip/iplink.c
> @@ -87,7 +87,7 @@ void iplink_usage(void)
>  		fprintf(stderr, "\n");
>  		fprintf(stderr, "TYPE := { vlan | veth | vcan | dummy | ifb | macvlan | macvtap |\n");
>  		fprintf(stderr, "          bridge | bond | ipoib | ip6tnl | ipip | sit | vxlan |\n");
> -		fprintf(stderr, "          gre | gretap | ip6gre | ip6gretap | vti }\n");
> +		fprintf(stderr, "          gre | gretap | ip6gre | ip6gretap | vti | nlmon }\n");
>  	}
>  	exit(-1);
>  }

accepted
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/ip/iplink.c b/ip/iplink.c
index de9ef5d..5e428da 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -87,7 +87,7 @@  void iplink_usage(void)
 		fprintf(stderr, "\n");
 		fprintf(stderr, "TYPE := { vlan | veth | vcan | dummy | ifb | macvlan | macvtap |\n");
 		fprintf(stderr, "          bridge | bond | ipoib | ip6tnl | ipip | sit | vxlan |\n");
-		fprintf(stderr, "          gre | gretap | ip6gre | ip6gretap | vti }\n");
+		fprintf(stderr, "          gre | gretap | ip6gre | ip6gretap | vti | nlmon }\n");
 	}
 	exit(-1);
 }