| Message ID | 1405396592-909-1-git-send-email-Larry.Finger@lwfinger.net |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, Jul 14, 2014 at 10:56:32PM -0500, Larry Finger wrote: > Commit 4fb6a37c3f94c1cb4b828bfcc4347771e1628f88 by Andrey Utkin > <andrey.krieger.utkin@gmail.com> and entitled "staging: rtl8192ee: > "Correct bitmask in comparsion" fixed what appeared to be a typo. After > consultation with the Realtek engineers, merely testing for a 2T2R device > is sufficient to ensure that the TX MCS map will equal 0x0c, thus the second > test can be ignored. > > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> > --- > drivers/staging/rtl8192ee/base.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8192ee/base.c b/drivers/staging/rtl8192ee/base.c > index 71ed12e..b8b897a 100644 > --- a/drivers/staging/rtl8192ee/base.c > +++ b/drivers/staging/rtl8192ee/base.c > @@ -826,8 +826,7 @@ static u8 _rtl_get_vht_highest_n_rate(struct ieee80211_hw *hw, > u8 hw_rate; > u16 map = le16_to_cpu(sta->vht_cap.vht_mcs.tx_mcs_map); > > - if ((get_rf_type(rtlphy) == RF_2T2R) && > - (map & 0x000c) != 0x000c) { > + if ((get_rf_type(rtlphy) == RF_2T2R) { I don't think you test built this change :( -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/rtl8192ee/base.c b/drivers/staging/rtl8192ee/base.c index 71ed12e..b8b897a 100644 --- a/drivers/staging/rtl8192ee/base.c +++ b/drivers/staging/rtl8192ee/base.c @@ -826,8 +826,7 @@ static u8 _rtl_get_vht_highest_n_rate(struct ieee80211_hw *hw, u8 hw_rate; u16 map = le16_to_cpu(sta->vht_cap.vht_mcs.tx_mcs_map); - if ((get_rf_type(rtlphy) == RF_2T2R) && - (map & 0x000c) != 0x000c) { + if ((get_rf_type(rtlphy) == RF_2T2R) { if ((map & 0x000c) >> 2 == IEEE80211_VHT_MCS_SUPPORT_0_7) hw_rate = rtlpriv->cfg->maps[RTL_RC_VHT_RATE_2SS_MCS7];
Commit 4fb6a37c3f94c1cb4b828bfcc4347771e1628f88 by Andrey Utkin <andrey.krieger.utkin@gmail.com> and entitled "staging: rtl8192ee: "Correct bitmask in comparsion" fixed what appeared to be a typo. After consultation with the Realtek engineers, merely testing for a 2T2R device is sufficient to ensure that the TX MCS map will equal 0x0c, thus the second test can be ignored. Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> --- drivers/staging/rtl8192ee/base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)