From patchwork Tue Oct 27 12:52:13 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 36982 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D9D3BB7BE9 for ; Tue, 27 Oct 2009 23:53:05 +1100 (EST) Received: from localhost ([127.0.0.1]:37199 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2lXq-00022y-9Q for incoming@patchwork.ozlabs.org; Tue, 27 Oct 2009 08:53:02 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N2lXD-00022l-Uk for qemu-devel@nongnu.org; Tue, 27 Oct 2009 08:52:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N2lX8-00022B-JP for qemu-devel@nongnu.org; Tue, 27 Oct 2009 08:52:22 -0400 Received: from [199.232.76.173] (port=37173 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2lX8-000228-Ee for qemu-devel@nongnu.org; Tue, 27 Oct 2009 08:52:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8151) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N2lX7-0008A6-Vu for qemu-devel@nongnu.org; Tue, 27 Oct 2009 08:52:18 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9RCqGa2008240 for ; Tue, 27 Oct 2009 08:52:16 -0400 Received: from crossbow.pond.sub.org (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9RCqFat029435 for ; Tue, 27 Oct 2009 08:52:16 -0400 Received: by crossbow.pond.sub.org (Postfix, from userid 500) id 1BBD326408; Tue, 27 Oct 2009 13:52:14 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Tue, 27 Oct 2009 13:52:13 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: [Qemu-devel] [PATCH] qdev: Tag isa-fdc, PIIX3 IDE and PIIX4 IDE as no-user X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org These devices are created automatically, and attempting to create another one with -device fails with "qemu: hardware error: register_ioport_write: invalid opaque". Signed-off-by: Markus Armbruster Acked-by: Gerd Hoffmann --- hw/fdc.c | 1 + hw/ide/piix.c | 2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index b584b98..d09783c 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1999,6 +1999,7 @@ static ISADeviceInfo isa_fdc_info = { .init = isabus_fdc_init1, .qdev.name = "isa-fdc", .qdev.size = sizeof(fdctrl_isabus_t), + .qdev.no_user = 1, .qdev.vmsd = &vmstate_fdc, .qdev.reset = fdctrl_external_reset_isa, .qdev.props = (Property[]) { diff --git a/hw/ide/piix.c b/hw/ide/piix.c index ddce684..a2c7282 100644 --- a/hw/ide/piix.c +++ b/hw/ide/piix.c @@ -178,10 +178,12 @@ static PCIDeviceInfo piix_ide_info[] = { { .qdev.name = "PIIX3 IDE", .qdev.size = sizeof(PCIIDEState), + .qdev.no_user = 1, .init = pci_piix3_ide_initfn, },{ .qdev.name = "PIIX4 IDE", .qdev.size = sizeof(PCIIDEState), + .qdev.no_user = 1, .init = pci_piix4_ide_initfn, },{ /* end of list */