Patchwork qdev: Tag isa-fdc, PIIX3 IDE and PIIX4 IDE as no-user

login
register
mail settings
Submitter Markus Armbruster
Date Oct. 27, 2009, 12:52 p.m.
Message ID <m3ocntngn6.fsf@crossbow.pond.sub.org>
Download mbox | patch
Permalink /patch/36982/
State New
Headers show

Comments

Markus Armbruster - Oct. 27, 2009, 12:52 p.m.
These devices are created automatically, and attempting to create
another one with -device fails with "qemu: hardware error:
register_ioport_write: invalid opaque".

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/fdc.c      |    1 +
 hw/ide/piix.c |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)
Gerd Hoffmann - Oct. 27, 2009, 4:33 p.m.
On 10/27/09 13:52, Markus Armbruster wrote:
> These devices are created automatically, and attempting to create
> another one with -device fails with "qemu: hardware error:
> register_ioport_write: invalid opaque".
>
> Signed-off-by: Markus Armbruster<armbru@redhat.com>

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

cheers,
   Gerd

Patch

diff --git a/hw/fdc.c b/hw/fdc.c
index b584b98..d09783c 100644
--- a/hw/fdc.c
+++ b/hw/fdc.c
@@ -1999,6 +1999,7 @@  static ISADeviceInfo isa_fdc_info = {
     .init = isabus_fdc_init1,
     .qdev.name  = "isa-fdc",
     .qdev.size  = sizeof(fdctrl_isabus_t),
+    .qdev.no_user = 1,
     .qdev.vmsd  = &vmstate_fdc,
     .qdev.reset = fdctrl_external_reset_isa,
     .qdev.props = (Property[]) {
diff --git a/hw/ide/piix.c b/hw/ide/piix.c
index ddce684..a2c7282 100644
--- a/hw/ide/piix.c
+++ b/hw/ide/piix.c
@@ -178,10 +178,12 @@  static PCIDeviceInfo piix_ide_info[] = {
     {
         .qdev.name    = "PIIX3 IDE",
         .qdev.size    = sizeof(PCIIDEState),
+        .qdev.no_user = 1,
         .init         = pci_piix3_ide_initfn,
     },{
         .qdev.name    = "PIIX4 IDE",
         .qdev.size    = sizeof(PCIIDEState),
+        .qdev.no_user = 1,
         .init         = pci_piix4_ide_initfn,
     },{
         /* end of list */