diff mbox

[U-Boot,v1] arm: include config.h in vectors.S

Message ID 1405314094-25139-1-git-send-email-judge.packham@gmail.com
State Superseded
Delegated to: Albert ARIBAUD
Headers show

Commit Message

Chris Packham July 14, 2014, 5:01 a.m. UTC
In order to use configuration flags it is necessary to include config.h.
Without this arm targets that use CONFIG_USE_IRQ or CONFIG_SPL_BUILD
won't get the correct code.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
Resent without corporate disclaimer

 arch/arm/lib/vectors.S |    1 +
 1 file changed, 1 insertion(+)

Comments

Chris Packham Aug. 5, 2014, 8:30 a.m. UTC | #1
On 14/07/14 17:01, Chris Packham wrote:
> In order to use configuration flags it is necessary to include config.h.
> Without this arm targets that use CONFIG_USE_IRQ or CONFIG_SPL_BUILD
> won't get the correct code.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> Resent without corporate disclaimer
> 
>  arch/arm/lib/vectors.S |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
> index e6538ef..a8b6c53 100644
> --- a/arch/arm/lib/vectors.S
> +++ b/arch/arm/lib/vectors.S
> @@ -12,6 +12,7 @@
>   *
>   * SPDX-License-Identifier:	GPL-2.0+
>   */
> +#include <config.h>
>  
>  /*
>   *************************************************************************
> 

Ping?
Christian Riesch Aug. 20, 2014, 6:23 a.m. UTC | #2
Hi Albert,

On Tue, Aug 5, 2014 at 10:30 AM, Chris Packham <judge.packham@gmail.com> wrote:
> On 14/07/14 17:01, Chris Packham wrote:
>> In order to use configuration flags it is necessary to include config.h.
>> Without this arm targets that use CONFIG_USE_IRQ or CONFIG_SPL_BUILD
>> won't get the correct code.
>>
>> Signed-off-by: Chris Packham <judge.packham@gmail.com>

I submitted a similar patch on July 7, see
http://patchwork.ozlabs.org/patch/367453/. Please apply either of them
to get the issue fixed.
Thanks,
Christian

>> ---
>> Resent without corporate disclaimer
>>
>>  arch/arm/lib/vectors.S |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
>> index e6538ef..a8b6c53 100644
>> --- a/arch/arm/lib/vectors.S
>> +++ b/arch/arm/lib/vectors.S
>> @@ -12,6 +12,7 @@
>>   *
>>   * SPDX-License-Identifier:  GPL-2.0+
>>   */
>> +#include <config.h>
>>
>>  /*
>>   *************************************************************************
>>
>
> Ping?
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Albert ARIBAUD Aug. 20, 2014, 9:33 a.m. UTC | #3
Hi Chris,

On Tue, 05 Aug 2014 20:30:36 +1200, Chris Packham
<judge.packham@gmail.com> wrote:

> On 14/07/14 17:01, Chris Packham wrote:
> > In order to use configuration flags it is necessary to include config.h.
> > Without this arm targets that use CONFIG_USE_IRQ or CONFIG_SPL_BUILD
> > won't get the correct code.
> > 
> > Signed-off-by: Chris Packham <judge.packham@gmail.com>
> > ---
> > Resent without corporate disclaimer
> > 
> >  arch/arm/lib/vectors.S |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
> > index e6538ef..a8b6c53 100644
> > --- a/arch/arm/lib/vectors.S
> > +++ b/arch/arm/lib/vectors.S
> > @@ -12,6 +12,7 @@
> >   *
> >   * SPDX-License-Identifier:	GPL-2.0+
> >   */
> > +#include <config.h>
> >  
> >  /*
> >   *************************************************************************
> > 
> 
> Ping?

Underway -- will get in Real Soon Now.

Amicalement,
diff mbox

Patch

diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
index e6538ef..a8b6c53 100644
--- a/arch/arm/lib/vectors.S
+++ b/arch/arm/lib/vectors.S
@@ -12,6 +12,7 @@ 
  *
  * SPDX-License-Identifier:	GPL-2.0+
  */
+#include <config.h>
 
 /*
  *************************************************************************