| Message ID | 1405088313-20048-3-git-send-email-mperttunen@nvidia.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On 07/11/2014 08:18 AM, Mikko Perttunen wrote: > Remove the TEGRA124_CLK_EMC cell value define for tegra124-car > from the binding headers. This clock has never been able to do > anything and is being replaced with a separate EMC driver with > its own device tree node. Removing the define ensures that any > user will not mistakenly refer to <&tegra_car TEGRA124_CLK_EMC> > instead of <&emc> or similar. If the clock physically exists in HW, I see no reason to remove it from the binding definition, even if we don't implement it (or remove the implementation of it) in the Linux clock driver. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Yeah, I'll drop this one. - Mikko On 22/07/14 01:37, Stephen Warren wrote: > On 07/11/2014 08:18 AM, Mikko Perttunen wrote: >> Remove the TEGRA124_CLK_EMC cell value define for tegra124-car >> from the binding headers. This clock has never been able to do >> anything and is being replaced with a separate EMC driver with >> its own device tree node. Removing the define ensures that any >> user will not mistakenly refer to <&tegra_car TEGRA124_CLK_EMC> >> instead of <&emc> or similar. > > If the clock physically exists in HW, I see no reason to remove it from > the binding definition, even if we don't implement it (or remove the > implementation of it) in the Linux clock driver. > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/dt-bindings/clock/tegra124-car.h b/include/dt-bindings/clock/tegra124-car.h index 8a4c589..4faabce 100644 --- a/include/dt-bindings/clock/tegra124-car.h +++ b/include/dt-bindings/clock/tegra124-car.h @@ -73,7 +73,7 @@ #define TEGRA124_CLK_I2C2 54 #define TEGRA124_CLK_UARTC 55 #define TEGRA124_CLK_MIPI_CAL 56 -#define TEGRA124_CLK_EMC 57 +/* 57 */ #define TEGRA124_CLK_USB2 58 #define TEGRA124_CLK_USB3 59 /* 60 */
Remove the TEGRA124_CLK_EMC cell value define for tegra124-car from the binding headers. This clock has never been able to do anything and is being replaced with a separate EMC driver with its own device tree node. Removing the define ensures that any user will not mistakenly refer to <&tegra_car TEGRA124_CLK_EMC> instead of <&emc> or similar. Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> --- include/dt-bindings/clock/tegra124-car.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)