Patchwork USB: remove info() macro from usb mtd drivers

login
register
mail settings
Submitter Greg KH
Date Oct. 10, 2008, 5:13 a.m.
Message ID <20081010051321.GA32687@kroah.com>
Download mbox | patch
Permalink /patch/3687/
State Accepted
Commit b887265c165f94917d0f565b1883a6e7b3c8388c
Headers show

Comments

Greg KH - Oct. 10, 2008, 5:13 a.m.
From: Greg Kroah-Hartman <gregkh@suse.de>

USB should not be having it's own printk macros, so remove info() and
use the system-wide standard of dev_info() wherever possible.

Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
David, this has been in the USB tree for a few months now, sorry for not
sending it to you sooner.  I can easily keep it in my tree and send it
to Linus for this merge if you want me to, or you can take it in your
tree, which ever you want me to do.

thanks,

greg k-h

 drivers/mtd/nand/alauda.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
David Woodhouse - Oct. 10, 2008, 6:40 a.m.
On Thu, 2008-10-09 at 22:13 -0700, Greg KH wrote:
> From: Greg Kroah-Hartman <gregkh@suse.de>
> 
> USB should not be having it's own printk macros, so remove info() and
> use the system-wide standard of dev_info() wherever possible.
> 
> Cc: David Woodhouse <dwmw2@infradead.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> ---
> David, this has been in the USB tree for a few months now, sorry for not
> sending it to you sooner.  I can easily keep it in my tree and send it
> to Linus for this merge if you want me to, or you can take it in your
> tree, which ever you want me to do.

Since you already seem to have it, you might as well keep it. Thanks.
Greg KH - Oct. 10, 2008, 4:11 p.m.
On Fri, Oct 10, 2008 at 07:40:56AM +0100, David Woodhouse wrote:
> On Thu, 2008-10-09 at 22:13 -0700, Greg KH wrote:
> > From: Greg Kroah-Hartman <gregkh@suse.de>
> > 
> > USB should not be having it's own printk macros, so remove info() and
> > use the system-wide standard of dev_info() wherever possible.
> > 
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> > ---
> > David, this has been in the USB tree for a few months now, sorry for not
> > sending it to you sooner.  I can easily keep it in my tree and send it
> > to Linus for this merge if you want me to, or you can take it in your
> > tree, which ever you want me to do.
> 
> Since you already seem to have it, you might as well keep it. Thanks.

Great, will do, thanks.

greg k-h

Patch

--- a/drivers/mtd/nand/alauda.c
+++ b/drivers/mtd/nand/alauda.c
@@ -691,7 +691,7 @@  static int alauda_probe(struct usb_inter
 	al[0].port = ALAUDA_PORT_XD;
 	al[1].port = ALAUDA_PORT_SM;
 
-	info("alauda probed");
+	dev_info(&interface->dev, "alauda probed\n");
 	alauda_check_media(al);
 	alauda_check_media(al+1);
 
@@ -716,7 +716,7 @@  static void alauda_disconnect(struct usb
 	if (al)
 		kref_put(&al->kref, alauda_delete);
 
-	info("alauda gone");
+	dev_info(&interface->dev, "alauda gone");
 }
 
 static struct usb_driver alauda_driver = {