diff mbox

[126/156] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR

Message ID 1404839947-1086-127-git-send-email-mdroth@linux.vnet.ibm.com
State New
Headers show

Commit Message

Michael Roth July 8, 2014, 5:18 p.m. UTC 
From: Markus Armbruster <armbru@redhat.com>

Introduced in commit a8d8ecb.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit f25391c2a6ef1674384204265429520ea50e82bc)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 block/qapi.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox

Patch

diff --git a/block/qapi.c b/block/qapi.c
index 5880b3e..e9007c9 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -471,6 +471,7 @@  static void dump_qobject(fprintf_function func_fprintf, void *f,
         case QTYPE_QERROR: {
             QString *value = qerror_human((QError *)obj);
             func_fprintf(f, "%s", qstring_get_str(value));
+            QDECREF(value);
             break;
         }
         case QTYPE_NONE: