Message ID | 20140708222023.GA11829@himangi-Dell |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
From: Himangi Saraogi <himangi774@gmail.com> Date: Wed, 9 Jul 2014 03:50:23 +0530 > Use BUG_ON(x) rather than if(x) BUG(); > > The semantic patch that fixes this problem is as follows: > > // <smpl> > @@ identifier x; @@ > -if (x) BUG(); > +BUG_ON(x); > // </smpl> > > Signed-off-by: Himangi Saraogi <himangi774@gmail.com> > Acked-by: Julia Lawall <julia.lawall@lip6.fr> Please repost this with a proper subject line, correcting "iaf_packet". -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index b85c67c..cda8552 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -551,8 +551,7 @@ static void prb_setup_retire_blk_timer(struct packet_sock *po, int tx_ring) { struct tpacket_kbdq_core *pkc; - if (tx_ring) - BUG(); + BUG_ON(tx_ring); pkc = tx_ring ? GET_PBDQC_FROM_RB(&po->tx_ring) : GET_PBDQC_FROM_RB(&po->rx_ring);