From patchwork Fri Oct 23 16:49:52 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark McLoughlin X-Patchwork-Id: 36794 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id F02BDB7BA3 for ; Sat, 24 Oct 2009 03:52:34 +1100 (EST) Received: from localhost ([127.0.0.1]:54161 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N1NNP-0001vY-3l for incoming@patchwork.ozlabs.org; Fri, 23 Oct 2009 12:52:31 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N1NMp-0001u9-Oa for qemu-devel@nongnu.org; Fri, 23 Oct 2009 12:51:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N1NMk-0001qJ-GO for qemu-devel@nongnu.org; Fri, 23 Oct 2009 12:51:54 -0400 Received: from [199.232.76.173] (port=35392 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N1NMk-0001q5-BG for qemu-devel@nongnu.org; Fri, 23 Oct 2009 12:51:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23362) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N1NMj-000603-SE for qemu-devel@nongnu.org; Fri, 23 Oct 2009 12:51:50 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9NGplQU024098; Fri, 23 Oct 2009 12:51:47 -0400 Received: from [IPv6:::1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9NGpjb2015747; Fri, 23 Oct 2009 12:51:46 -0400 Subject: Re: [Qemu-devel] [PATCH 00/15] Some networking code re-organization From: Mark McLoughlin To: Anthony Liguori In-Reply-To: <4AE1B32D.6080502@codemonkey.ws> References: <1256230156-29652-1-git-send-email-markmc@redhat.com> <4AE0C1D4.8080309@codemonkey.ws> <1256291986.31881.61.camel@blaa> <4AE1B32D.6080502@codemonkey.ws> Date: Fri, 23 Oct 2009 17:49:52 +0100 Message-Id: <1256316592.31881.87.camel@blaa> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: qemu-devel@nongnu.org X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mark McLoughlin List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Fri, 2009-10-23 at 08:44 -0500, Anthony Liguori wrote: > Mark McLoughlin wrote: > > On Thu, 2009-10-22 at 15:34 -0500, Anthony Liguori wrote: > > > >> This series doesn't build for me. I get dependency errors even after a > >> full rebuild. I'm building from a separate directory fwiw. > >> > > > > Don't see it here, I'm afraid - any more details? > > > > Btw, it's all pushed to http://repo.or.cz/w/qemu/markmc.git if that > > helps > > > > Building master of that tree. Source code is in > /home/anthony/git/qemu. Build dir is /home/anthony/obj/qemu-tmp. > Configure line is ~/git/qemu/configure > --kerneldir=/home/anthony/git/kvm-userspace/kernel. > > Attached the make V=1 output and configure output. Thanks, I'll add using a separate build dir to my test matrix :) Incremental patch below, will post a v2 of 01/15, also pushed to net-cleanup.v2 branch Thanks, Mark. diff --git a/Makefile b/Makefile index 44bd7ef..41107a5 100644 --- a/Makefile +++ b/Makefile @@ -229,7 +229,7 @@ clean: # avoid old build problems by removing potentially incorrect old files rm -f config.mak op-i386.h opc-i386.h gen-op-i386.h op-arm.h opc-arm.h gen-op-arm.h rm -f *.o *.d *.a $(TOOLS) TAGS cscope.* *.pod *~ */*~ - rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d + rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o block/*.d net/*.o net/*.d rm -f qemu-img-cmds.h $(MAKE) -C tests clean for d in $(ALL_SUBDIRS) libhw32 libhw64 libuser; do \ @@ -413,4 +413,4 @@ tarbin: $(mandir)/man8/qemu-nbd.8 # Include automatically generated dependency files --include $(wildcard *.d audio/*.d slirp/*.d block/*.d) +-include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d) diff --git a/configure b/configure index 4ccdebe..b9fc32b 100755 --- a/configure +++ b/configure @@ -2533,7 +2533,7 @@ done # for target in $targets # build tree in object directory if source path is different from current one if test "$source_path_used" = "yes" ; then - DIRS="tests tests/cris slirp audio block pc-bios/optionrom" + DIRS="tests tests/cris slirp audio block net pc-bios/optionrom" DIRS="$DIRS roms/pcbios roms/seabios roms/vgabios" FILES="Makefile tests/Makefile" FILES="$FILES tests/cris/Makefile tests/cris/.gdbinit"