Patchwork powerpc allyesconfig fix

login
register
mail settings
Submitter Nick
Date July 8, 2014, 5:04 a.m.
Message ID <1404795849-25609-1-git-send-email-xerofoify@gmail.com>
Download mbox | patch
Permalink /patch/367793/
State Not Applicable
Headers show

Comments

Nick - July 8, 2014, 5:04 a.m.
powerpc:allmodconfig has been failing for some time with the following
error.

arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1

A number of attempts to fix the problem by moving around code have been
unsuccessful and resulted in failed builds for some configurations and
the discovery of toolchain bugs.

Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
While this is less than perfect, it avoids substantial code changes
which would otherwise be necessary just to make COMPILE_TEST builds
happy and might have undesired side effects.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/powerpc/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Stephen Rothwell - July 8, 2014, 6:04 a.m.
Hi Nicholas,

On Tue,  8 Jul 2014 01:04:09 -0400 Nicholas Krause <xerofoify@gmail.com> wrote:
>
> powerpc:allmodconfig has been failing for some time with the following
> error.

This patch has already bee submitted directly by Guenter, however for
future reference:  when you submit someone else's patch, you should
include a From line as the first line of the email body containing their
email address and you should include a Signed-off-by line from yourself.
Nick - July 8, 2014, 4:35 p.m.
From: Stephen Rothwell wrote on Tue, Jul 8, 2014 at 2:04 AM
Subject: Re: powerpc allyesconfig fix

Hi Nicholas,

On Tue,  8 Jul 2014 01:04:09 -0400 Nicholas Krause <xerofoify@gmail.com> wrote:
>
> powerpc:allmodconfig has been failing for some time with the following
> error.

This patch has already bee submitted directly by Guenter, however for
future reference:  when you submit someone else's patch, you should
include a From line as the first line of the email body containing their
email address and you should include a Signed-off-by line from yourself.

--
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au


Hey Stephen,
Thanks for the heads up on submitting other people's patches. It would
be great if you can push this up into Linus's tree
for the next developer release.
--
Cheers Nick
Guenter Roeck - July 8, 2014, 4:43 p.m.
On Tue, Jul 08, 2014 at 12:35:27PM -0400, Nick Krause wrote:
> From: Stephen Rothwell wrote on Tue, Jul 8, 2014 at 2:04 AM
> Subject: Re: powerpc allyesconfig fix
> 
> Hi Nicholas,
> 
> On Tue,  8 Jul 2014 01:04:09 -0400 Nicholas Krause <xerofoify@gmail.com> wrote:
> >
> > powerpc:allmodconfig has been failing for some time with the following
> > error.
> 
> This patch has already bee submitted directly by Guenter, however for
> future reference:  when you submit someone else's patch, you should
> include a From line as the first line of the email body containing their
> email address and you should include a Signed-off-by line from yourself.
> 
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> 
> 
> Hey Stephen,
> Thanks for the heads up on submitting other people's patches. It would
> be great if you can push this up into Linus's tree
> for the next developer release.

Ben already mentioned that he would pick it up.

Guenter

Patch

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index bd6dd6e..fefe7c8 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -414,7 +414,7 @@  config KEXEC
 config CRASH_DUMP
 	bool "Build a kdump crash kernel"
 	depends on PPC64 || 6xx || FSL_BOOKE || (44x && !SMP)
-	select RELOCATABLE if PPC64 || 44x || FSL_BOOKE
+	select RELOCATABLE if (PPC64 && !COMPILE_TEST) || 44x || FSL_BOOKE
 	help
 	  Build a kernel suitable for use as a kdump capture kernel.
 	  The same kernel binary can be used as production kernel and dump
@@ -1017,6 +1017,7 @@  endmenu
 if PPC64
 config RELOCATABLE
 	bool "Build a relocatable kernel"
+	depends on !COMPILE_TEST
 	select NONSTATIC_KERNEL
 	help
 	  This builds a kernel image that is capable of running anywhere