Patchwork [03/20] sb16: remove IO_READ_PROTO

login
register
mail settings
Submitter Juan Quintela
Date Oct. 22, 2009, 2:36 p.m.
Message ID <626b98860a5002e8e7330e870b3962352a42494f.1256221008.git.quintela@redhat.com>
Download mbox | patch
Permalink /patch/36675/
State New
Headers show

Comments

Juan Quintela - Oct. 22, 2009, 2:36 p.m.
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 hw/sb16.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)
malc - Oct. 22, 2009, 8:32 p.m.
On Thu, 22 Oct 2009, Juan Quintela wrote:

No.

[..snip..]
Anthony Liguori - Oct. 22, 2009, 8:41 p.m.
malc wrote:
> On Thu, 22 Oct 2009, Juan Quintela wrote:
>
> No.
>   

I was going to say, "Because..."

But seeing as the commit message was completely empty, "No." is a pretty 
reasonable response.

Juan, can you explain the justification for removing this a bit more?

Regards,

Anthony Liguori

Patch

diff --git a/hw/sb16.c b/hw/sb16.c
index 8654b7d..f4f96d1 100644
--- a/hw/sb16.c
+++ b/hw/sb16.c
@@ -40,8 +40,6 @@ 
 #define ldebug(...)
 #endif

-#define IO_READ_PROTO(name)                             \
-    uint32_t name (void *opaque, uint32_t nport)
 #define IO_WRITE_PROTO(name)                                    \
     void name (void *opaque, uint32_t nport, uint32_t val)

@@ -961,7 +959,7 @@  static IO_WRITE_PROTO (dsp_write)
     }
 }

-static IO_READ_PROTO (dsp_read)
+static uint32_t dsp_read (void *opaque, uint32_t nport)
 {
     SB16State *s = opaque;
     int iport, retval, ack = 0;
@@ -1129,7 +1127,7 @@  static IO_WRITE_PROTO (mixer_write_indexw)
     mixer_write_datab (opaque, nport, (val >> 8) & 0xff);
 }

-static IO_READ_PROTO (mixer_read)
+static uint32_t mixer_read (void *opaque, uint32_t nport)
 {
     SB16State *s = opaque;