| Message ID | 1404294938-9968-1-git-send-email-jiri@resnulli.us |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, Jul 02, 2014 at 11:55:38AM +0200, Jiri Pirko wrote: >These warnings are no longer relevant. Even when last slave is >removed, there is a valid address assigned to bond (random). >The correct functionality of vlans is ensured by maintaining unicast >list in vlan_sync_address(). > >Suggested-by: Jay Vosburgh <jay.vosburgh@canonical.com> >Signed-off-by: Jiri Pirko <jiri@resnulli.us> Thanks for following up on this. Acked-by: Veaceslav Falico <vfalico@gmail.com> >--- > drivers/net/bonding/bond_main.c | 7 ------- > 1 file changed, 7 deletions(-) > >diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >index ffefb70..09dc3ef 100644 >--- a/drivers/net/bonding/bond_main.c >+++ b/drivers/net/bonding/bond_main.c >@@ -1754,13 +1754,6 @@ static int __bond_release_one(struct net_device *bond_dev, > if (!bond_has_slaves(bond)) { > bond_set_carrier(bond); > eth_hw_addr_random(bond_dev); >- >- if (vlan_uses_dev(bond_dev)) { >- pr_warn("%s: Warning: clearing HW address of %s while it still has VLANs\n", >- bond_dev->name, bond_dev->name); >- pr_warn("%s: When re-adding slaves, make sure the bond's HW address matches its VLANs\n", >- bond_dev->name); >- } > } > > unblock_netpoll_tx(); >-- >1.9.0 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jiri Pirko <jiri@resnulli.us> Date: Wed, 2 Jul 2014 11:55:38 +0200 > These warnings are no longer relevant. Even when last slave is > removed, there is a valid address assigned to bond (random). > The correct functionality of vlans is ensured by maintaining unicast > list in vlan_sync_address(). > > Suggested-by: Jay Vosburgh <jay.vosburgh@canonical.com> > Signed-off-by: Jiri Pirko <jiri@resnulli.us> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index ffefb70..09dc3ef 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1754,13 +1754,6 @@ static int __bond_release_one(struct net_device *bond_dev, if (!bond_has_slaves(bond)) { bond_set_carrier(bond); eth_hw_addr_random(bond_dev); - - if (vlan_uses_dev(bond_dev)) { - pr_warn("%s: Warning: clearing HW address of %s while it still has VLANs\n", - bond_dev->name, bond_dev->name); - pr_warn("%s: When re-adding slaves, make sure the bond's HW address matches its VLANs\n", - bond_dev->name); - } } unblock_netpoll_tx();
These warnings are no longer relevant. Even when last slave is removed, there is a valid address assigned to bond (random). The correct functionality of vlans is ensured by maintaining unicast list in vlan_sync_address(). Suggested-by: Jay Vosburgh <jay.vosburgh@canonical.com> Signed-off-by: Jiri Pirko <jiri@resnulli.us> --- drivers/net/bonding/bond_main.c | 7 ------- 1 file changed, 7 deletions(-)