| Message ID | 1404281615-31186-1-git-send-email-shaveta@freescale.com |
|---|---|
| State | Changes Requested |
| Delegated to: | York Sun |
| Headers | show |
On 07/01/2014 11:13 PM, Shaveta Leekha wrote: > CPC1 is not being enabled by default as powerpc is supposed to > use only CPC2. > > Signed-off-by: Shaveta Leekha <shaveta@freescale.com> > Signed-off-by: Sandeep Singh <Sandeep@freescale.com> > --- > include/configs/B4860QDS.h | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/include/configs/B4860QDS.h b/include/configs/B4860QDS.h > index 1af9ba6..53fdac7 100644 > --- a/include/configs/B4860QDS.h > +++ b/include/configs/B4860QDS.h > @@ -820,8 +820,14 @@ unsigned long get_board_ddr_clk(void); > > #define __USB_PHY_TYPE ulpi > > +#ifdef CONFIG_PPC_B4860 > +#define HWCONFIG "hwconfig=fsl_ddr:ctlr_intlv=null,en_cpc:cpc2," > +#else > +#define HWCONFIG "hwconfig=fsl_ddr:ctlr_intlv=null," > +#endif > + > #define CONFIG_EXTRA_ENV_SETTINGS \ > - "hwconfig=fsl_ddr:ctlr_intlv=null," \ > + HWCONFIG \ > "bank_intlv=cs0_cs1;" \ > "usb1:dr_mode=host,phy_type=" __stringify(__USB_PHY_TYPE) "\0"\ > "netdev=eth0\0" \ > Did you try this patch on a board? You inserted "en_cpc:cpc2" at a wrong place. You actually broke into the setting for DDR. When you move out hwconfig string, you only removed partially. York
diff --git a/include/configs/B4860QDS.h b/include/configs/B4860QDS.h index 1af9ba6..53fdac7 100644 --- a/include/configs/B4860QDS.h +++ b/include/configs/B4860QDS.h @@ -820,8 +820,14 @@ unsigned long get_board_ddr_clk(void); #define __USB_PHY_TYPE ulpi +#ifdef CONFIG_PPC_B4860 +#define HWCONFIG "hwconfig=fsl_ddr:ctlr_intlv=null,en_cpc:cpc2," +#else +#define HWCONFIG "hwconfig=fsl_ddr:ctlr_intlv=null," +#endif + #define CONFIG_EXTRA_ENV_SETTINGS \ - "hwconfig=fsl_ddr:ctlr_intlv=null," \ + HWCONFIG \ "bank_intlv=cs0_cs1;" \ "usb1:dr_mode=host,phy_type=" __stringify(__USB_PHY_TYPE) "\0"\ "netdev=eth0\0" \