From patchwork Tue Jul 1 02:31:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Krause X-Patchwork-Id: 365855 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id CFE991400CF for ; Tue, 1 Jul 2014 12:32:25 +1000 (EST) Received: from ozlabs.org (ozlabs.org [103.22.144.67]) by lists.ozlabs.org (Postfix) with ESMTP id B05931A069B for ; Tue, 1 Jul 2014 12:32:25 +1000 (EST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from mail-ie0-x232.google.com (mail-ie0-x232.google.com [IPv6:2607:f8b0:4001:c03::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 7B2821A0014 for ; Tue, 1 Jul 2014 12:31:47 +1000 (EST) Received: by mail-ie0-f178.google.com with SMTP id rd18so7693111iec.9 for ; Mon, 30 Jun 2014 19:31:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=UduaQfRhhLkZ7JrxLzoM7Sa9bainHAgDdMjZxPzNSEA=; b=xnlqnNFXB13zSZlegv3qrl3L8cb5Cgv8GOo3O9c1XbH55DQLUQIsRKR2ZXFkYBrVOE NHq569NuPs2sN+KRfoPuMoNvRDCY+wIg+mnE4Emt12KVi5UB1ZD4l02jbcZKke7/KJ49 AAR2kbJz8EzkLWgaBo6IxmQEI6eT81GhMcogQzaES8ip95wNxTQ0kFdASCkvxYsTKxZS paPGp1DR9+Gox9fQyrEMpak9ZPw1pQb+C+OqCxIr0mcXZyvVeQSE7p3Y0YhKo4psa9tU t3GuUTfEb13P/6CfaY+1G+Ck7Ld0BRowtY8dk9SLTDD73eAOAs7rbcD3ROU2rlER/pJU +9VQ== X-Received: by 10.50.112.132 with SMTP id iq4mr2447402igb.45.1404181904900; Mon, 30 Jun 2014 19:31:44 -0700 (PDT) Received: from nick-System-Product-Name.phub.net.cable.rogers.com (CPE0026f3330aca-CM0026f3330ac6.cpe.net.cable.rogers.com. [99.232.64.167]) by mx.google.com with ESMTPSA id b10sm3206799igx.6.2014.06.30.19.31.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 30 Jun 2014 19:31:44 -0700 (PDT) From: Nicholas Krause To: benh@kernel.crashing.org Subject: [PATCH] Remove FIXME messages in arch/powerpc/sysdev/uic.c Date: Mon, 30 Jun 2014 22:31:40 -0400 Message-Id: <1404181900-4452-1-git-send-email-xerofoify@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: linuxppc-dev@lists.ozlabs.org, paulus@samba.org, linux-kernel@vger.kernel.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" This removes FIXME messages in the function uic_init_one as this FIXMEs are not valid due to the kernel being better to panic due to boards without these allocated not being able to service IRQs. Signed-off-by: Nicholas Krause --- arch/powerpc/sysdev/uic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/sysdev/uic.c b/arch/powerpc/sysdev/uic.c index 9203393..937f6a5 100644 --- a/arch/powerpc/sysdev/uic.c +++ b/arch/powerpc/sysdev/uic.c @@ -239,7 +239,7 @@ static struct uic * __init uic_init_one(struct device_node *node) uic = kzalloc(sizeof(*uic), GFP_KERNEL); if (! uic) - return NULL; /* FIXME: panic? */ + return NULL; raw_spin_lock_init(&uic->lock); indexp = of_get_property(node, "cell-index", &len); @@ -261,7 +261,7 @@ static struct uic * __init uic_init_one(struct device_node *node) uic->irqhost = irq_domain_add_linear(node, NR_UIC_INTS, &uic_host_ops, uic); if (! uic->irqhost) - return NULL; /* FIXME: panic? */ + return NULL; /* Start with all interrupts disabled, level and non-critical */ mtdcr(uic->dcrbase + UIC_ER, 0);