diff mbox

[v2] uclibc: disable parallel build for uClibc 0.9.31

Message ID 1404145013-7553-1-git-send-email-abrodkin@synopsys.com
State Accepted
Commit 4a530b6ed312a69dabdc98a1e10795238fd4d1e2
Headers show

Commit Message

Alexey Brodkin June 30, 2014, 4:16 p.m. UTC
This is only required for uClibc 0.9.31 and this veriosn is only used by
AVR32 so could be safely removed together with AVR32.

Even 0.9.32 builds well in parallel (at least on x86) so IMHO there's no need
in >= 0.9.33, just disable for a particular broken version.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>

Cc: Anton Kolesov <akolesov@synopsys.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>

---
In v2 I replaced MAKE_UCLIBC  with UCLIBC_MAKE as suggested by Thomas.
---
 package/uclibc/uclibc.mk | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

Comments

Peter Korsgaard July 1, 2014, 1:04 p.m. UTC | #1
>>>>> "Alexey" == Alexey Brodkin <Alexey.Brodkin@synopsys.com> writes:

 > This is only required for uClibc 0.9.31 and this veriosn is only used by
 > AVR32 so could be safely removed together with AVR32.

 > Even 0.9.32 builds well in parallel (at least on x86) so IMHO there's no need
 > in >= 0.9.33, just disable for a particular broken version.

 > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>

 > Cc: Anton Kolesov <akolesov@synopsys.com>
 > Cc: Peter Korsgaard <peter@korsgaard.com>
 > Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
 > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>

 > ---
 > In v2 I replaced MAKE_UCLIBC  with UCLIBC_MAKE as suggested by Thomas.

Committed, thanks.
diff mbox

Patch

diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
index 28a8a08..caa5553 100644
--- a/package/uclibc/uclibc.mk
+++ b/package/uclibc/uclibc.mk
@@ -493,8 +493,20 @@  define UCLIBC_BUILD_TEST_SUITE
 endef
 endif
 
+# In uClibc 0.9.31 parallel building is broken so we have to disable it
+# Fortunately uClibc 0.9.31 is only used by AVR32 and in its turn AVR32 is
+# about to be removed from buildroot.
+#
+# So as soon as AVR32 is removed please revert this patch so instead of
+# UCLIBC_MAKE normal "MAKE" is used in UCLIBC_BUILD_CMDS
+ifeq ($(BR2_UCLIBC_VERSION_0_9_31),y)
+	UCLIBC_MAKE = $(MAKE1)
+else
+	UCLIBC_MAKE = $(MAKE)
+endif
+
 define UCLIBC_BUILD_CMDS
-	$(MAKE) -C $(@D) \
+	$(UCLIBC_MAKE) -C $(@D) \
 		$(UCLIBC_MAKE_FLAGS) \
 		PREFIX= \
 		DEVEL_PREFIX=/ \