diff mbox

[1/3] mtd: hisilicon: add device tree node for nand controller

Message ID 1404115409-20200-2-git-send-email-wangzhou.bry@gmail.com
State Superseded
Headers show

Commit Message

Sherlock Wang June 30, 2014, 8:03 a.m. UTC
Signed-off-by: Zhou Wang <wangzhou.bry@gmail.com>
---
 arch/arm/boot/dts/hip04.dtsi |   31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

Comments

Jerome FORISSIER July 9, 2014, 7:08 a.m. UTC | #1
On 30-Jun-14 10:03, Zhou Wang wrote:
> Signed-off-by: Zhou Wang <wangzhou.bry@gmail.com>
> ---
>  arch/arm/boot/dts/hip04.dtsi |   31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/hip04.dtsi b/arch/arm/boot/dts/hip04.dtsi
> index abb42ca..e63fc61 100644
> --- a/arch/arm/boot/dts/hip04.dtsi
> +++ b/arch/arm/boot/dts/hip04.dtsi
> @@ -386,5 +386,36 @@
>  				interrupts = <0 389 4>;
>  			};
>  		};
> +
> +		nand: nand@4020000 {
> +			compatible = "hisilicon,504-nfc";

In PATCH 2/3 and 3/3 you are using "hisilicon,nfc504".

> +			reg = <0x4020000 0x10000>, <0x5000000 0x1000>;
> +			interrupts = <0 379 4>;
> +			nand-bus-width = <8>;
> +			nand-ecc-mode = "none";
> +			hisi,nand-ecc-bits = <0>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			partition@0 {
> +				label = "nand_text";
> +				reg = <0x00000000 0x00400000>;
> +			};
> +
> +			partition@00400000 {
> +				label = "nand_monitor";
> +				reg = <0x00400000 0x00400000>;
> +			};
> +
> +			partition@00800000 {
> +				label = "nand_kernel";
> +				reg = <0x00800000 0x00800000>;
> +			};
> +
> +			partition@01000000 {
> +				label = "nand_fs";
> +				reg = <0x01000000 0x1f000000>;
> +			};
> +		};
>  	};
>  };
>
Sherlock Wang July 11, 2014, 2:40 a.m. UTC | #2
On 2014年07月09日 15:08, Jerome FORISSIER wrote:
> On 30-Jun-14 10:03, Zhou Wang wrote:
>> Signed-off-by: Zhou Wang <wangzhou.bry@gmail.com>
>> ---
>>   arch/arm/boot/dts/hip04.dtsi |   31 +++++++++++++++++++++++++++++++
>>   1 file changed, 31 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/hip04.dtsi b/arch/arm/boot/dts/hip04.dtsi
>> index abb42ca..e63fc61 100644
>> --- a/arch/arm/boot/dts/hip04.dtsi
>> +++ b/arch/arm/boot/dts/hip04.dtsi
>> @@ -386,5 +386,36 @@
>>   				interrupts = <0 389 4>;
>>   			};
>>   		};
>> +
>> +		nand: nand@4020000 {
>> +			compatible = "hisilicon,504-nfc";
>
> In PATCH 2/3 and 3/3 you are using "hisilicon,nfc504".
>

It was my mistake. All should be "hisilicon,504-nfc". Thanks a lot.

>> +			reg = <0x4020000 0x10000>, <0x5000000 0x1000>;
>> +			interrupts = <0 379 4>;
>> +			nand-bus-width = <8>;
>> +			nand-ecc-mode = "none";
>> +			hisi,nand-ecc-bits = <0>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +
>> +			partition@0 {
>> +				label = "nand_text";
>> +				reg = <0x00000000 0x00400000>;
>> +			};
>> +
>> +			partition@00400000 {
>> +				label = "nand_monitor";
>> +				reg = <0x00400000 0x00400000>;
>> +			};
>> +
>> +			partition@00800000 {
>> +				label = "nand_kernel";
>> +				reg = <0x00800000 0x00800000>;
>> +			};
>> +
>> +			partition@01000000 {
>> +				label = "nand_fs";
>> +				reg = <0x01000000 0x1f000000>;
>> +			};
>> +		};
>>   	};
>>   };
>>
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/hip04.dtsi b/arch/arm/boot/dts/hip04.dtsi
index abb42ca..e63fc61 100644
--- a/arch/arm/boot/dts/hip04.dtsi
+++ b/arch/arm/boot/dts/hip04.dtsi
@@ -386,5 +386,36 @@ 
 				interrupts = <0 389 4>;
 			};
 		};
+
+		nand: nand@4020000 {
+			compatible = "hisilicon,504-nfc";
+			reg = <0x4020000 0x10000>, <0x5000000 0x1000>;
+			interrupts = <0 379 4>;
+			nand-bus-width = <8>;
+			nand-ecc-mode = "none";
+			hisi,nand-ecc-bits = <0>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			partition@0 {
+				label = "nand_text";
+				reg = <0x00000000 0x00400000>;
+			};
+
+			partition@00400000 {
+				label = "nand_monitor";
+				reg = <0x00400000 0x00400000>;
+			};
+
+			partition@00800000 {
+				label = "nand_kernel";
+				reg = <0x00800000 0x00800000>;
+			};
+
+			partition@01000000 {
+				label = "nand_fs";
+				reg = <0x01000000 0x1f000000>;
+			};
+		};
 	};
 };