From patchwork Wed Oct 21 10:18:00 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [08/12] target-arm: optimize thumb2 load/store multiple ops Date: Wed, 21 Oct 2009 00:18:00 -0000 From: Juha.Riihimaki@nokia.com X-Patchwork-Id: 36527 Message-Id: To: Thumb2 load/store multiple instructions can be slightly optimized by loading the register offset constant into a variable outside the register loop and using the preloaded variable inside the loop instead of reloading the offset value to a temporary variable on each loop iteration. This causes less TCG ops to be generated for a Thumb2 load/ store multiple instruction. Signed-off-by: Juha Riihimäki --- continue; @@ -7386,8 +7387,9 @@ static int disas_thumb2_insn(CPUState *env, DisasContext *s, uint16_t insn_hw1) tmp = load_reg(s, i); gen_st32(tmp, addr, IS_USER(s)); } - tcg_gen_addi_i32(addr, addr, 4); + tcg_gen_add_i32(addr, addr, tmp2); } + tcg_temp_free_i32(tmp2); if (insn & (1 << 21)) { /* Base register writeback. */ if (insn & (1 << 24)) { diff --git a/target-arm/translate.c b/target-arm/translate.c index c92ecc6..abb3105 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -7370,6 +7370,7 @@ static int disas_thumb2_insn(CPUState *env, DisasContext *s, uint16_t insn_hw1) tcg_gen_addi_i32(addr, addr, -offset); } + tmp2 = tcg_const_i32(4); for (i = 0; i < 16; i++) { if ((insn & (1 << i)) == 0)