Patchwork [04/12] target-arm: allow modifying vfp fpexc en bit only

login
register
mail settings
Submitter Juha.Riihimaki@nokia.com
Date Oct. 21, 2009, 10:17 a.m.
Message ID <45F683F1-AC7E-4700-8615-FEB548311484@nokia.com>
Download mbox | patch
Permalink /patch/36524/
State New
Headers show

Comments

Juha.Riihimaki@nokia.com - Oct. 21, 2009, 10:17 a.m.
All other bits except for the EN in the VFP FPEXC register are defined  
as subarchitecture specific and real functionality for any of the  
other bits has not been implemented in QEMU. However, current code  
allows modifying all bits in the VFP FPEXC register leading to  
problems when guest code is writing 1's to the subarchitecture  
specific bits and checking whether the bits stay up to verify the  
existence of functionality which in fact does not exist in QEMU.

Signed-off-by: Juha Riihimäki <juha.riihimaki@nokia.com>
---
                              break;

Patch

diff --git a/target-arm/translate.c b/target-arm/translate.c
index d027572..07ee638 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -2788,6 +2788,9 @@  static int disas_vfp_insn(CPUState * env,  
DisasContext *s, uint32_t insn)
                          case ARM_VFP_FPEXC:
                              if (IS_USER(s))
                                  return 1;
+                            /* TODO: VFP subarchitecture support.
+                             * For now, keep the EN bit only */
+                            tcg_gen_andi_i32(tmp, tmp, 1 << 30);
                              store_cpu_field(tmp, vfp.xregs[rn]);
                              gen_lookup_tb(s);