From patchwork Wed Oct 21 10:17:35 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Juha.Riihimaki@nokia.com X-Patchwork-Id: 36522 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A1515B7B9A for ; Wed, 21 Oct 2009 21:35:57 +1100 (EST) Received: from localhost ([127.0.0.1]:33577 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0YXo-0004CV-S8 for incoming@patchwork.ozlabs.org; Wed, 21 Oct 2009 06:35:52 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N0YGd-0006NI-5v for qemu-devel@nongnu.org; Wed, 21 Oct 2009 06:18:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N0YGY-0006Ka-NF for qemu-devel@nongnu.org; Wed, 21 Oct 2009 06:18:06 -0400 Received: from [199.232.76.173] (port=43280 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0YGX-0006KH-Ve for qemu-devel@nongnu.org; Wed, 21 Oct 2009 06:18:02 -0400 Received: from smtp.nokia.com ([192.100.122.230]:49876 helo=mgw-mx03.nokia.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N0YGX-0000Wb-1f for qemu-devel@nongnu.org; Wed, 21 Oct 2009 06:18:01 -0400 Received: from vaebh106.NOE.Nokia.com (vaebh106.europe.nokia.com [10.160.244.32]) by mgw-mx03.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id n9LAHn7V024423 for ; Wed, 21 Oct 2009 13:17:58 +0300 Received: from vaebh104.NOE.Nokia.com ([10.160.244.30]) by vaebh106.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 21 Oct 2009 13:17:44 +0300 Received: from smtp.mgd.nokia.com ([65.54.30.8]) by vaebh104.NOE.Nokia.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.3959); Wed, 21 Oct 2009 13:17:39 +0300 Received: from NOK-EUMSG-05.mgdnok.nokia.com ([65.54.30.90]) by nok-am1mhub-04.mgdnok.nokia.com ([65.54.30.8]) with mapi; Wed, 21 Oct 2009 12:17:20 +0200 From: To: Date: Wed, 21 Oct 2009 12:17:35 +0200 Thread-Topic: [PATCH 01/12] target-arm: fix resource leak in gen_set_cpsr macro Thread-Index: AcpSN6xlIa8pn1zzSTKYU2ticdcs5w== Message-ID: <59832F36-4565-4EEA-9BC7-844463C2BE3B@nokia.com> Accept-Language: en, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: acceptlanguage: en, en-US MIME-Version: 1.0 X-OriginalArrivalTime: 21 Oct 2009 10:17:39.0593 (UTC) FILETIME=[B7ED1F90:01CA5237] X-Nokia-AV: Clean X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Subject: [Qemu-devel] [PATCH 01/12] target-arm: fix resource leak in gen_set_cpsr macro X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Current implementation of the gen_set_cpsr macro creates a new temporary tcg variable through the tcg_const_i32 call but never marks it dead. Signed-off-by: Juha Riihimäki --- #define gen_set_nzcv(var) gen_set_cpsr(var, CPSR_NZCV) diff --git a/target-arm/translate.c b/target-arm/translate.c index bc51bcb..bda105e 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -184,7 +184,12 @@ static void store_reg(DisasContext *s, int reg, TCGv var) #define gen_uxtb16(var) gen_helper_uxtb16(var, var) -#define gen_set_cpsr(var, mask) gen_helper_cpsr_write(var, tcg_const_i32(mask)) +#define gen_set_cpsr(var, mask) \ +{ \ + TCGv tmp_mask = tcg_const_i32(mask); \ + gen_helper_cpsr_write(var, tmp_mask); \ + tcg_temp_free_i32(tmp_mask); \ +} /* Set NZCV flags from the high 4 bits of var. */