| Message ID | E1X0Xvb-0001Mu-JB@rmk-PC.arm.linux.org.uk |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Russell, On Fri, Jun 27, 2014 at 04:19:03PM +0100, Russell King wrote: > The iMX6 gigabit FEC does not support half-duplex gigabit operation. > Phys attacked to the FEC may support this, and we currently do nothing Even if it might be interpreted as an attack to connect such a phy to the FEC, I'd still call it "attach" here :-) Uwe
On Tue, Jul 08, 2014 at 08:46:11AM +0200, Uwe Kleine-König wrote: > Hi Russell, > > On Fri, Jun 27, 2014 at 04:19:03PM +0100, Russell King wrote: > > The iMX6 gigabit FEC does not support half-duplex gigabit operation. > > Phys attacked to the FEC may support this, and we currently do nothing > Even if it might be interpreted as an attack to connect such a phy to > the FEC, I'd still call it "attach" here :-) You are right, but unfortunately your comment comes too late; this is the actual submission for David to integrate the patches into net-next rather than for review, and David has already integrated the change into his tree. Hence, the comment is unable to be fixed now. Thanks anyway.
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 77037fd377b8..a91fe68030e6 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1667,6 +1667,7 @@ static int fec_enet_mii_probe(struct net_device *ndev) /* mask with MAC supported features */ if (id_entry->driver_data & FEC_QUIRK_HAS_GBIT) { phy_dev->supported &= PHY_GBIT_FEATURES; + phy_dev->supported &= ~SUPPORTED_1000baseT_Half; #if !defined(CONFIG_M5272) phy_dev->supported |= SUPPORTED_Pause; #endif
The iMX6 gigabit FEC does not support half-duplex gigabit operation. Phys attacked to the FEC may support this, and we currently do nothing to disable this feature. This may result in an invalid configuration. Mask out phy support for gigabit half-duplex operation. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> --- drivers/net/ethernet/freescale/fec_main.c | 1 + 1 file changed, 1 insertion(+)