From patchwork Wed Oct 21 01:52:46 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: TeLeMan X-Patchwork-Id: 36487 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 781C1B7B9E for ; Wed, 21 Oct 2009 12:53:20 +1100 (EST) Received: from localhost ([127.0.0.1]:55431 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0QO5-0000sm-K3 for incoming@patchwork.ozlabs.org; Tue, 20 Oct 2009 21:53:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N0QNh-0000sY-FE for qemu-devel@nongnu.org; Tue, 20 Oct 2009 21:52:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N0QNc-0000s5-Vp for qemu-devel@nongnu.org; Tue, 20 Oct 2009 21:52:53 -0400 Received: from [199.232.76.173] (port=49674 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0QNc-0000s2-Qt for qemu-devel@nongnu.org; Tue, 20 Oct 2009 21:52:48 -0400 Received: from kuber.nabble.com ([216.139.236.158]:57121) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N0QNc-0004Bv-D0 for qemu-devel@nongnu.org; Tue, 20 Oct 2009 21:52:48 -0400 Received: from isper.nabble.com ([192.168.236.156]) by kuber.nabble.com with esmtp (Exim 4.63) (envelope-from ) id 1N0QNa-0003dD-60 for qemu-devel@nongnu.org; Tue, 20 Oct 2009 18:52:46 -0700 Message-ID: <25985345.post@talk.nabble.com> Date: Tue, 20 Oct 2009 18:52:46 -0700 (PDT) From: TeLeMan To: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc MIME-Version: 1.0 X-Nabble-From: geleman@gmail.com X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org cirrus_post_load() will be executed twice when loading vm states and then the wrong physical memory will be registered. This issue may lead to crash qemu. --- hw/cirrus_vga.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) VMSTATE_STRUCT(cirrus_vga, PCICirrusVGAState, 0, diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 9dfe76a..262ba9c 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -3017,7 +3017,6 @@ static const VMStateDescription vmstate_pci_cirrus_vga = { .version_id = 2, .minimum_version_id = 2, .minimum_version_id_old = 2, - .post_load = cirrus_post_load, .fields = (VMStateField []) { VMSTATE_PCI_DEVICE(dev, PCICirrusVGAState),