| Message ID | 1403810481-10025-50-git-send-email-gustavo@zacarias.com.ar |
|---|---|
| State | Accepted |
| Headers | show |
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes: > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > package/udpcast/udpcast.mk | 2 ++ > 1 file changed, 2 insertions(+) > diff --git a/package/udpcast/udpcast.mk b/package/udpcast/udpcast.mk > index 786a88e..0cd3b27 100644 > --- a/package/udpcast/udpcast.mk > +++ b/package/udpcast/udpcast.mk > @@ -7,6 +7,8 @@ > UDPCAST_VERSION = 20120424 > UDPCAST_SITE = http://www.udpcast.linux.lu/download > UDPCAST_DEPENDENCIES = host-m4 > +UDPCAST_LICENSE = BSD-2c, GPLv2 > +UDPCAST_LICENSE_FILES = COPYING fec.c::fec_license() lists it as GPLv2+, so I've fixed that and committed, thanks. > define UDPCAST_REMOVE_UDP_SENDER > rm -f $(TARGET_DIR)/usr/sbin/udp-sender > -- > 1.8.5.5 > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
On 07/01/2014 07:43 PM, Peter Korsgaard wrote: > fec.c::fec_license() lists it as GPLv2+, so I've fixed that and > committed, thanks. Careful there, look at COPYING. Regards.
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes: > On 07/01/2014 07:43 PM, Peter Korsgaard wrote: >> fec.c::fec_license() lists it as GPLv2+, so I've fixed that and >> committed, thanks. > Careful there, look at COPYING. Yes, it's not really clear. From COPYING: The bulk of the code (everything except fec.c) is covered by the GPL 2.0 licence (See http://www.gnu.org/licenses/gpl.txt) Fec.c is covered by a BSD-like licence From fec_licence() (which gets printed to the user when they request the license details of the udpcast utilities): " udpcast and its FEC code are free software\n" "\n" " you can redistribute udpcast core functionality and/or\n" " it them under the terms of the GNU General Public License as\n" " published by the Free Software Foundation; either version 2 of\n" " the License, or (at your option) any later version.\n" ... "the FEC code is covered by the following license:\n" "fec.c -- forward error correction based on Vandermonde matrices\n" So the question is if the license should be BSD-2c (fec.c), GPLv2+ (rest) or BSD-2c (fec.c), GPLv2 (rest) Sticking to GPLv2 is safest, but I say the license info that gets printed to the user is more "important" than what a source file says. Comments?
diff --git a/package/udpcast/udpcast.mk b/package/udpcast/udpcast.mk index 786a88e..0cd3b27 100644 --- a/package/udpcast/udpcast.mk +++ b/package/udpcast/udpcast.mk @@ -7,6 +7,8 @@ UDPCAST_VERSION = 20120424 UDPCAST_SITE = http://www.udpcast.linux.lu/download UDPCAST_DEPENDENCIES = host-m4 +UDPCAST_LICENSE = BSD-2c, GPLv2 +UDPCAST_LICENSE_FILES = COPYING define UDPCAST_REMOVE_UDP_SENDER rm -f $(TARGET_DIR)/usr/sbin/udp-sender
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- package/udpcast/udpcast.mk | 2 ++ 1 file changed, 2 insertions(+)