Patchwork [U-Boot] common: main.c: make show_boot_progress __weak

login
register
mail settings
Submitter Jeroen Hofstee
Date June 26, 2014, 6:18 p.m.
Message ID <1403806711-2881-1-git-send-email-jeroen@myspectrum.nl>
Download mbox | patch
Permalink /patch/364637/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Jeroen Hofstee - June 26, 2014, 6:18 p.m.
This not only looks a bit better it also prevents a
warning with W=1 (no previous prototype).

Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
 common/main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Simon Glass - July 8, 2014, 6:24 p.m.
On 26 June 2014 12:18, Jeroen Hofstee <jeroen@myspectrum.nl> wrote:
> This not only looks a bit better it also prevents a
> warning with W=1 (no previous prototype).
>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>

Acked-by: Simon Glass <sjg@chromium.org>
Tom Rini - July 21, 2014, 8:42 p.m.
On Thu, Jun 26, 2014 at 08:18:31PM +0200, Jeroen Hofstee wrote:

> This not only looks a bit better it also prevents a
> warning with W=1 (no previous prototype).
> 
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

Patch

diff --git a/common/main.c b/common/main.c
index 32618f1..2979fbe 100644
--- a/common/main.c
+++ b/common/main.c
@@ -17,8 +17,7 @@  DECLARE_GLOBAL_DATA_PTR;
 /*
  * Board-specific Platform code can reimplement show_boot_progress () if needed
  */
-void inline __show_boot_progress (int val) {}
-void show_boot_progress (int val) __attribute__((weak, alias("__show_boot_progress")));
+__weak void show_boot_progress(int val) {}
 
 static void modem_init(void)
 {