diff mbox

qemu-char: initialize chr_write_lock

Message ID 1403783111-28592-1-git-send-email-batuzovk@ispras.ru
State New
Headers show

Commit Message

Kirill Batuzov June 26, 2014, 11:45 a.m. UTC 
chr_write_lock was introduced in commit 9005b2a7589540a3733b3abdcfbccfe7746cd1a1
but was used uninitialized. It caused segmentation fault on windows hosts.

Add missing lock initialization to qemu_chr_alloc.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Fam Zheng <famz@redhat.com>
Signed-off-by: Kirill Batuzov <batuzovk@ispras.ru>
Signed-off-by: Nikita Belov <zodiac@ispras.ru>
---
 qemu-char.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Paolo Bonzini June 26, 2014, 11:47 a.m. UTC | #1 
Il 26/06/2014 13:45, Kirill Batuzov ha scritto:
> chr_write_lock was introduced in commit 9005b2a7589540a3733b3abdcfbccfe7746cd1a1
> but was used uninitialized. It caused segmentation fault on windows hosts.

A similar patch is already on the list.  Thanks anyway for your 
contribution!

Paolo
diff mbox

Patch

diff --git a/qemu-char.c b/qemu-char.c
index 2e50a10..17bd360 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -94,6 +94,7 @@  static QTAILQ_HEAD(CharDriverStateHead, CharDriverState) chardevs =
 CharDriverState *qemu_chr_alloc(void)
 {
     CharDriverState *chr = g_malloc0(sizeof(CharDriverState));
+    qemu_mutex_init(&chr->chr_write_lock);
     return chr;
 }