From patchwork Tue Oct 20 07:13:45 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 36444 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 807FDB7B8F for ; Tue, 20 Oct 2009 18:21:05 +1100 (EST) Received: from localhost ([127.0.0.1]:44994 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N091c-0006RR-R2 for incoming@patchwork.ozlabs.org; Tue, 20 Oct 2009 03:20:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N08vb-0003zW-1Y for qemu-devel@nongnu.org; Tue, 20 Oct 2009 03:14:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N08vW-0003vs-0Z for qemu-devel@nongnu.org; Tue, 20 Oct 2009 03:14:42 -0400 Received: from [199.232.76.173] (port=39795 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N08vV-0003vf-RH for qemu-devel@nongnu.org; Tue, 20 Oct 2009 03:14:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33115) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N08vV-0007l3-BQ for qemu-devel@nongnu.org; Tue, 20 Oct 2009 03:14:37 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9K7Ea3R015651 for ; Tue, 20 Oct 2009 03:14:36 -0400 Received: from localhost (vpn-12-92.rdu.redhat.com [10.11.12.92]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9K7EY41030183; Tue, 20 Oct 2009 03:14:35 -0400 From: Amit Shah To: qemu-devel@nongnu.org Date: Tue, 20 Oct 2009 12:43:45 +0530 Message-Id: <1256022825-16180-4-git-send-email-amit.shah@redhat.com> In-Reply-To: <1256022825-16180-3-git-send-email-amit.shah@redhat.com> References: <1256022825-16180-1-git-send-email-amit.shah@redhat.com> <1256022825-16180-2-git-send-email-amit.shah@redhat.com> <1256022825-16180-3-git-send-email-amit.shah@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.21 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Amit Shah Subject: [Qemu-devel] [PATCH v9 3/3] virtio-console: Add a new virtserialport device for generic serial port support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch adds generic serial ports over the virtio serial bus. These ports have a few more options that are not relevant for virtio console ports: the ability to cache buffers that are received for a port while it's disconnected, setting of limits to the bytes that are cached so as to prevent OOM conditions, etc. Sample uses for such a device can be obtaining info from the guest like the file systems used, apps installed, etc. for offline usage and logged-in users, clipboard copy-paste, etc. for online usage. For requirements, use-cases, test cases and some history see http://www.linux-kvm.org/page/VMchannel_Requirements Signed-off-by: Amit Shah --- hw/virtio-console.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index ef32820..fec346c 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -107,3 +107,41 @@ static void virtcon_register(void) virtio_serial_port_qdev_register(&virtcon_info); } device_init(virtcon_register) + + +/* Generic Virtio Serial Ports */ +static int virtserial_port_initfn(VirtIOSerialDevice *dev) +{ + VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, &dev->qdev); + VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port); + + port->info = dev->info; + + if (vcon->chr) { + qemu_chr_add_handlers(vcon->chr, chr_can_read, chr_read, chr_event, + vcon); + } + return 0; +} + +static VirtIOSerialPortInfo virtserial_port_info = { + .qdev.name = "virtserialport", + .qdev.size = sizeof(VirtConsole), + .init = virtserial_port_initfn, + .have_data = flush_buf, + .qdev.props = (Property[]) { + DEFINE_PROP_CHR("chardev", VirtConsole, chr), + DEFINE_PROP_STRING("name", VirtIOSerialPort, name), + DEFINE_PROP_INT32("cache_buffers", VirtIOSerialPort, cache_buffers, 1), + DEFINE_PROP_UINT64("byte_limit", VirtIOSerialPort, byte_limit, 0), + DEFINE_PROP_UINT64("guest_byte_limit", VirtIOSerialPort, + guest_byte_limit, 0), + DEFINE_PROP_END_OF_LIST(), + }, +}; + +static void virtserial_port_register(void) +{ + virtio_serial_port_qdev_register(&virtserial_port_info); +} +device_init(virtserial_port_register)