Patchwork [1/2] vmstate: u64 support

login
register
mail settings
Submitter Juan Quintela
Date Oct. 19, 2009, 7:07 p.m.
Message ID <a2c88c5745846df531174f86c250ddaf1feeb93a.1255979118.git.quintela@redhat.com>
Download mbox | patch
Permalink /patch/36419/
State New
Headers show

Comments

Juan Quintela - Oct. 19, 2009, 7:07 p.m.
This is needed due to the difference betewen 'unsigned long' and 'unsigned
long long' types.  They don't typecheck.

This allows to use directly linux kernel structures.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 hw/hw.h  |   13 +++++++++++++
 savevm.c |   23 +++++++++++++++++++++++
 2 files changed, 36 insertions(+), 0 deletions(-)
Glauber Costa - Oct. 20, 2009, 2:44 a.m.
On Mon, Oct 19, 2009 at 5:07 PM, Juan Quintela <quintela@redhat.com> wrote:
> This is needed due to the difference betewen 'unsigned long' and 'unsigned
> long long' types.  They don't typecheck.
>
> This allows to use directly linux kernel structures.
>

For the reference, it was included today in qemu-kvm.git as a dependency
to a patchset of mine.

Patch

diff --git a/hw/hw.h b/hw/hw.h
index 8c223f8..422cf18 100644
--- a/hw/hw.h
+++ b/hw/hw.h
@@ -330,6 +330,10 @@  extern const VMStateInfo vmstate_info_uint16;
 extern const VMStateInfo vmstate_info_uint32;
 extern const VMStateInfo vmstate_info_uint64;

+#ifdef __linux__
+extern const VMStateInfo vmstate_info_u64;
+#endif
+
 extern const VMStateInfo vmstate_info_timer;
 extern const VMStateInfo vmstate_info_ptimer;
 extern const VMStateInfo vmstate_info_buffer;
@@ -538,6 +542,15 @@  extern const VMStateDescription vmstate_i2c_slave;
 #define VMSTATE_UINT64(_f, _s)                                        \
     VMSTATE_UINT64_V(_f, _s, 0)

+/* This is needed because on linux __u64 is unsigned long long
+   and on glibc uint64_t is unsigned long on 64 bits */
+#ifdef __linux__
+#define VMSTATE_U64_V(_f, _s, _v)                                     \
+    VMSTATE_SINGLE(_f, _s, _v, vmstate_info_u64, __u64)
+#define VMSTATE_U64(_f, _s)                                           \
+    VMSTATE_UINT64_V(_f, _s, 0)
+#endif
+
 #define VMSTATE_UINT8_EQUAL(_f, _s)                                   \
     VMSTATE_SINGLE(_f, _s, 0, vmstate_info_uint8_equal, uint8_t)

diff --git a/savevm.c b/savevm.c
index 27a7686..d744725 100644
--- a/savevm.c
+++ b/savevm.c
@@ -848,6 +848,29 @@  const VMStateInfo vmstate_info_uint64 = {
     .put  = put_uint64,
 };

+/* 64 bit linux kernel unsigned int */
+
+#ifdef __linux__
+static int get_u64(QEMUFile *f, void *pv, size_t size)
+{
+    __u64 *v = pv;
+    qemu_get_be64s(f, (uint64_t *)v);
+    return 0;
+}
+
+static void put_u64(QEMUFile *f, void *pv, size_t size)
+{
+    __u64 *v = pv;
+    qemu_put_be64s(f, (uint64_t *)v);
+}
+
+const VMStateInfo vmstate_info_u64 = {
+    .name = "__u64",
+    .get  = get_u64,
+    .put  = put_u64,
+};
+#endif /* __linux__ */
+
 /* 8 bit int. See that the received value is the same than the one
    in the field */