From patchwork Mon Oct 19 06:36:53 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 36362 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C920EB7B9E for ; Mon, 19 Oct 2009 17:38:58 +1100 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1Mzlrh-0006Vp-Ob; Mon, 19 Oct 2009 06:37:09 +0000 Received: from mail-ew0-f228.google.com ([209.85.219.228]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1Mzlrb-0006VB-Hw for linux-mtd@lists.infradead.org; Mon, 19 Oct 2009 06:37:08 +0000 Received: by ewy28 with SMTP id 28so3977662ewy.18 for ; Sun, 18 Oct 2009 23:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=5OrXXPmZzmsBNcXIKLbaL2w2e+dwnRYUw9KeONcnoVk=; b=VbXszCAwgWayYAkus4Xfo/Ex5HRKUubsrZ4icbn2ED2bBXWDAcqAtZLH7w6fDO2Fld 0GqEeDu6nkNhMgM5YVjDugXIDC9PjRX4pNwTjIuCnG42a2ps7a64gRxaCXgZkbzUORLz ClbM1v9vt4Ds4O9sZyv0XdCfDMhY8JPaf+Ciw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=vJ9npOZlCrhn7BHwKW/B85QCY6O3ngOpiHUmtn6AOY9LHMHsCU8NydL08+Ie+NL4fu vM5ud7oX2+opPRsaXpLi/vW/BbUvk91PuoX9yoRSmznBwUgCi6gBEVeAv61p2eZgIY9b 1RoLzSPQlnduE7XeS/X1kPtmlAXsFnNjJITo4= Received: by 10.216.87.206 with SMTP id y56mr1651763wee.207.1255934221998; Sun, 18 Oct 2009 23:37:01 -0700 (PDT) Received: from localhost.localdomain ([220.110.185.192]) by mx.google.com with ESMTPS id t12sm9996211gvd.22.2009.10.18.23.36.58 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 18 Oct 2009 23:37:00 -0700 (PDT) Date: Mon, 19 Oct 2009 15:36:53 +0900 From: Akinobu Mita To: linux-mtd@lists.infradead.org Subject: [PATCH 2/2 -v2] MTD: Add nand_ecc test module Message-ID: <20091019063653.GA4486@localhost.localdomain> References: <1255932706-23824-1-git-send-email-akinobu.mita@gmail.com> <1255932706-23824-2-git-send-email-akinobu.mita@gmail.com> <20091019061550.GA23854@localhost.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20091019061550.GA23854@localhost.localdomain> User-Agent: Mutt/1.5.18 (2008-05-17) X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20091019_023703_813127_48E047C7 X-CRM114-Status: GOOD ( 20.11 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- _SUMMARY_ Cc: Artem Bityutskiy , David Woodhouse X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org * v2 changes - remove ifdef - make inject_single_bit_error static This module tests NAND ECC functions. The test is simple. 1. Create a 256 or 512 bytes block of data filled with random bytes (data) 2. Duplicate the data block and inject single bit error (error_data) 3. Try to correct error_data 4. Compare data and error_data This test is added into new MTD test group called MTD NAND test which requires MTD NAND device support. Signed-off-by: Akinobu Mita Cc: David Woodhouse Cc: linux-mtd@lists.infradead.org Cc: Artem Bityutskiy --- drivers/mtd/Kconfig | 6 +++ drivers/mtd/tests/Makefile | 1 + drivers/mtd/tests/nand_ecc-test.c | 76 +++++++++++++++++++++++++++++++++++++ 3 files changed, 83 insertions(+), 0 deletions(-) create mode 100644 drivers/mtd/tests/nand_ecc-test.c diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig index ecf90f5..abe5c7f 100644 --- a/drivers/mtd/Kconfig +++ b/drivers/mtd/Kconfig @@ -33,6 +33,12 @@ config MTD_TESTS should normally be compiled as kernel modules. The modules perform various checks and verifications when loaded. +config MTD_NAND_TESTS + tristate "MTD NAND tests support" + depends on MTD_TESTS && MTD_NAND + help + This option enables MTD tests which require NAND Device support. + config MTD_CONCAT tristate "MTD concatenating support" help diff --git a/drivers/mtd/tests/Makefile b/drivers/mtd/tests/Makefile index c1d5013..3994d5a 100644 --- a/drivers/mtd/tests/Makefile +++ b/drivers/mtd/tests/Makefile @@ -5,3 +5,4 @@ obj-$(CONFIG_MTD_TESTS) += mtd_speedtest.o obj-$(CONFIG_MTD_TESTS) += mtd_stresstest.o obj-$(CONFIG_MTD_TESTS) += mtd_subpagetest.o obj-$(CONFIG_MTD_TESTS) += mtd_torturetest.o +obj-$(CONFIG_MTD_NAND_TESTS) += nand_ecc-test.o diff --git a/drivers/mtd/tests/nand_ecc-test.c b/drivers/mtd/tests/nand_ecc-test.c new file mode 100644 index 0000000..6244f80 --- /dev/null +++ b/drivers/mtd/tests/nand_ecc-test.c @@ -0,0 +1,76 @@ +#include +#include +#include +#include +#include +#include +#include +#include +#include + +static void inject_single_bit_error(void *data, size_t size) +{ + unsigned long offset = random32() % (size * BITS_PER_BYTE); + + __change_bit(offset, data); +} + +static unsigned char data[512]; +static unsigned char error_data[512]; + +static int nand_ecc_test(const size_t size) +{ + unsigned char code[3]; + unsigned char error_code[3]; + char testname[30]; + + BUG_ON(sizeof(data) < size); + + sprintf(testname, "nand-ecc-%zu", size); + + get_random_bytes(data, size); + + memcpy(error_data, data, size); + inject_single_bit_error(error_data, size); + + __nand_calculate_ecc(data, size, code); + __nand_calculate_ecc(error_data, size, error_code); + __nand_correct_data(error_data, code, error_code, size); + + if (!memcmp(data, error_data, size)) { + printk(KERN_INFO "nand_ecc-test: ok - %s\n", testname); + return 0; + } + + printk(KERN_ERR "nand_ecc-test: not ok - %s\n", testname); + + printk(KERN_DEBUG "hexdump of data:\n"); + print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 16, 4, + data, size, false); + printk(KERN_DEBUG "hexdump of error data:\n"); + print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 16, 4, + error_data, size, false); + + return -1; +} + +static int __init ecc_test_init(void) +{ + srandom32(jiffies); + + nand_ecc_test(256); + nand_ecc_test(512); + + return 0; +} + +static void __exit ecc_test_exit(void) +{ +} + +module_init(ecc_test_init); +module_exit(ecc_test_exit); + +MODULE_DESCRIPTION("ECC test module"); +MODULE_AUTHOR("Akinobu Mita"); +MODULE_LICENSE("GPL");