diff mbox

[RFC,10/14] vga: Remove some "should be done in BIOS" comments

Message ID 1403565068-15229-11-git-send-email-benh@kernel.crashing.org
State New
Headers show

Commit Message

Benjamin Herrenschmidt June 23, 2014, 11:11 p.m. UTC 
Not all platforms have a VGA BIOS, powerpc typically relies on
using the DISPI interface to initialize the card.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 hw/display/vga.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Gerd Hoffmann June 30, 2014, 11:31 a.m. UTC | #1 
On Di, 2014-06-24 at 09:11 +1000, Benjamin Herrenschmidt wrote:
> Not all platforms have a VGA BIOS, powerpc typically relies on
> using the DISPI interface to initialize the card.

s/bios/guest/ and it would hold ;)

But the dispi interface is defined the way it is.  We are not going to
change it, even if it isn't perfect, as it is guest/host abi.  So the
comments are not very useful indeed ...

cheers,
  Gerd
diff mbox

Patch

diff --git a/hw/display/vga.c b/hw/display/vga.c
index 3b2cca5..909518c 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -695,14 +695,13 @@  void vbe_ioport_write_data(void *opaque, uint32_t addr, uint32_t val)
                         ((s->vbe_regs[VBE_DISPI_INDEX_BPP] + 7) >> 3);
                 s->vbe_start_addr = 0;
 
-                /* clear the screen (should be done in BIOS) */
+                /* clear the screen */
                 if (!(val & VBE_DISPI_NOCLEARMEM)) {
                     memset(s->vram_ptr, 0,
                            s->vbe_regs[VBE_DISPI_INDEX_YRES] * s->vbe_line_offset);
                 }
 
-                /* we initialize the VGA graphic mode (should be done
-                   in BIOS) */
+                /* we initialize the VGA graphic mode */
                 /* graphic mode + memory map 1 */
                 s->gr[VGA_GFX_MISC] = (s->gr[VGA_GFX_MISC] & ~0x0c) | 0x04 |
                     VGA_GR06_GRAPHICS_MODE;
@@ -735,7 +734,6 @@  void vbe_ioport_write_data(void *opaque, uint32_t addr, uint32_t val)
                     (shift_control << 5);
                 s->cr[VGA_CRTC_MAX_SCAN] &= ~0x9f; /* no double scan */
             } else {
-                /* XXX: the bios should do that */
                 s->bank_offset = 0;
             }
             s->dac_8bit = (val & VBE_DISPI_8BIT_DAC) > 0;