Patchwork Do not look for libattr. <sys/xattr.h> is enough

login
register
mail settings
Submitter Cristian Rodríguez
Date June 23, 2014, 9:31 p.m.
Message ID <1403559094-108983-1-git-send-email-crrodriguez@opensuse.org>
Download mbox | patch
Permalink /patch/363199/
State Accepted
Headers show

Comments

Cristian Rodríguez - June 23, 2014, 9:31 p.m.
---
 configure.ac                       | 5 -----
 src/libjunction/display-junction.c | 2 +-
 src/libjunction/junction.c         | 2 +-
 3 files changed, 2 insertions(+), 7 deletions(-)
Chuck Lever - June 23, 2014, 9:38 p.m.
Hi Cristian-

On Jun 23, 2014, at 5:31 PM, Cristian Rodríguez <crrodriguez@opensuse.org> wrote:

> ---
> configure.ac                       | 5 -----
> src/libjunction/display-junction.c | 2 +-
> src/libjunction/junction.c         | 2 +-
> 3 files changed, 2 insertions(+), 7 deletions(-)
> 

Thanks for your submission!

Please add a patch description that explains why this
change is necessary, and add a signed-off-by.



> diff --git a/configure.ac b/configure.ac
> index a35c798..f7a63cf 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -141,11 +141,6 @@ AC_CHECK_LIB([ssl], [SSL_CTX_new],
> 		 AC_DEFINE([HAVE_LIBSSL], [1],
> 			   [Define if you have libssl])],
> 		[AC_MSG_ERROR([libssl not found.])])
> -AC_CHECK_LIB([attr], [fgetxattr],
> -		[AC_SUBST([LIBATTR], ["-lattr"])
> -		 AC_DEFINE([HAVE_LIBATTR], [1],
> -			   [Define if you have libattr])],
> -		[AC_MSG_ERROR([libattr not found.])])
> AC_CHECK_LIB([gssapi_krb5], [gss_acquire_cred],
> 		[AC_SUBST([LIBGSSAPI_KRB5], ["-lgssapi_krb5"])
> 		 AC_DEFINE([HAVE_LIBGSSAPI_KRB5], [1],
> diff --git a/src/libjunction/display-junction.c b/src/libjunction/display-junction.c
> index ac5797b..2e924da 100644
> --- a/src/libjunction/display-junction.c
> +++ b/src/libjunction/display-junction.c
> @@ -35,7 +35,7 @@
> #include <locale.h>
> #include <langinfo.h>
> 
> -#include <attr/xattr.h>
> +#include <sys/xattr.h>
> 
> #include "junction.h"
> #include "junction-internal.h"
> diff --git a/src/libjunction/junction.c b/src/libjunction/junction.c
> index 7b7b2e4..71ccc7a 100644
> --- a/src/libjunction/junction.c
> +++ b/src/libjunction/junction.c
> @@ -38,7 +38,7 @@
> #include <errno.h>
> #include <dirent.h>
> 
> -#include <attr/xattr.h>
> +#include <sys/xattr.h>
> 
> #include "fedfs.h"
> #include "nsdb.h"
> -- 
> 2.0.0
> 

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

Patch

diff --git a/configure.ac b/configure.ac
index a35c798..f7a63cf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -141,11 +141,6 @@  AC_CHECK_LIB([ssl], [SSL_CTX_new],
 		 AC_DEFINE([HAVE_LIBSSL], [1],
 			   [Define if you have libssl])],
 		[AC_MSG_ERROR([libssl not found.])])
-AC_CHECK_LIB([attr], [fgetxattr],
-		[AC_SUBST([LIBATTR], ["-lattr"])
-		 AC_DEFINE([HAVE_LIBATTR], [1],
-			   [Define if you have libattr])],
-		[AC_MSG_ERROR([libattr not found.])])
 AC_CHECK_LIB([gssapi_krb5], [gss_acquire_cred],
 		[AC_SUBST([LIBGSSAPI_KRB5], ["-lgssapi_krb5"])
 		 AC_DEFINE([HAVE_LIBGSSAPI_KRB5], [1],
diff --git a/src/libjunction/display-junction.c b/src/libjunction/display-junction.c
index ac5797b..2e924da 100644
--- a/src/libjunction/display-junction.c
+++ b/src/libjunction/display-junction.c
@@ -35,7 +35,7 @@ 
 #include <locale.h>
 #include <langinfo.h>
 
-#include <attr/xattr.h>
+#include <sys/xattr.h>
 
 #include "junction.h"
 #include "junction-internal.h"
diff --git a/src/libjunction/junction.c b/src/libjunction/junction.c
index 7b7b2e4..71ccc7a 100644
--- a/src/libjunction/junction.c
+++ b/src/libjunction/junction.c
@@ -38,7 +38,7 @@ 
 #include <errno.h>
 #include <dirent.h>
 
-#include <attr/xattr.h>
+#include <sys/xattr.h>
 
 #include "fedfs.h"
 #include "nsdb.h"